ci: do not use -Dwarnings rust flag on coverage #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The coverage job uses the nightly toolchain due to a dependency on a nightly feature. Since all jobs uses the -Dwarnings rust flag however, this meant this job can break every day as the nightly toolchain adds new warnings. To avoid this issue and have a more stable job, stop setting this flag for all jobs, and only do it for jobs where it makes sense.
vthib
force-pushed
the
ci-stop-coverage-fail-on-warnings
branch
from
e886351
to
868cfd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The coverage job uses the nightly toolchain due to a dependency on a nightly feature. Since all jobs uses the -Dwarnings rust flag however, this meant this job can break every day as the nightly toolchain adds new warnings.
To avoid this issue and have a more stable job, stop setting this flag for all jobs, and only do it for jobs where it makes sense.