Skip to content

Commit

Permalink
ci: do not use -Dwarnings rust flag on coverage
Browse files Browse the repository at this point in the history
The coverage job uses the nightly toolchain due to a dependency on a
nightly feature. Since all jobs uses the -Dwarnings rust flag however,
this meant this job can break every day as the nightly toolchain adds
new warnings.

To avoid this issue and have a more stable job, stop setting this flag
for all jobs, and only do it for jobs where it makes sense.
  • Loading branch information
vthib committed Mar 6, 2024
1 parent 9d314ab commit 754d11b
Showing 1 changed file with 13 additions and 3 deletions.
16 changes: 13 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@ on:
schedule:
- cron: '45 4 * * 3'

env:
RUSTFLAGS: -Dwarnings

jobs:
test-linux:
name: Test ${{matrix.build}}
runs-on: ubuntu-22.04

env:
RUSTFLAGS: -Dwarnings

steps:
- name: Install openssl x86 and 32 support for gcc
if: ${{ matrix.build == 'linux32' }}
Expand Down Expand Up @@ -71,6 +71,9 @@ jobs:
name: Test ${{matrix.build}}
runs-on: windows-2022

env:
RUSTFLAGS: -Dwarnings

steps:
- uses: actions/checkout@v3

Expand Down Expand Up @@ -129,6 +132,9 @@ jobs:
name: Test Macos 12
runs-on: macos-12

env:
RUSTFLAGS: -Dwarnings

steps:
- uses: actions/checkout@v3

Expand Down Expand Up @@ -162,6 +168,8 @@ jobs:
clippy:
name: Clippy
runs-on: ubuntu-22.04
env:
RUSTFLAGS: -Dwarnings
steps:
- uses: actions/checkout@v3
- uses: dtolnay/rust-toolchain@stable
Expand Down Expand Up @@ -222,6 +230,8 @@ jobs:
msrv:
name: Rust 1.65.0
runs-on: ubuntu-22.04
env:
RUSTFLAGS: -Dwarnings
steps:
- uses: actions/checkout@v3
- uses: dtolnay/[email protected]
Expand Down

0 comments on commit 754d11b

Please sign in to comment.