Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address unused_qualifications lint issues from nightly #122

Merged

Conversation

demoray
Copy link
Contributor

@demoray demoray commented Mar 6, 2024

This is another change that is currently breaking the coverage task.

rustc 1.78.0-nightly (b6d2d841b 2024-03-05)

Similar to #121 , this is only here to address compilation issues highlighted by the coverage task with latest nightly.

Brian Caswell added 2 commits March 5, 2024 20:22
This is another change that is currently breaking the coverage task.
@demoray demoray mentioned this pull request Mar 6, 2024
@vthib
Copy link
Owner

vthib commented Mar 6, 2024

Never had much issues with new warnings/errors from nightly since I added the coverage job, and you're getting several in a few days. I've written #123 to mitigate the issue, although it won't work for everything (for this lint for example, it would not have worked).

@vthib vthib merged commit 9d314ab into vthib:master Mar 6, 2024
12 checks passed
@demoray demoray deleted the address-unused_qualifications-from-nightly branch March 6, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants