Fixes for better ROS integration #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xed it. TODO: test, if lvr2 is working when compiling and installing it outside of ros2 ws
renamed project to lvr2 instead of LAS_VEGAS otherwise ROS is complaining tested with mesh_tools
|
Successfully tested from someone other than me. Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added cmake as build tool instead of ament_cmake. I think it's better doing it like this since lvr2 is actually a standalone library. It compiles both as standalone cmake package and in a ROS2 - humble repository. I tested it with the mesh_tools.
Other changes: