Build in ROS1 or 2 with package.xml conditionals

[lucasw]

Found these in plotjuggler https://github.com/PlotJuggler/plotjuggler-ros-plugins/blob/main/package.xml - seems to build fine (along with mesh_tools) in my Ubuntu 23.10 catkin install workspace, also builds in a ros2 rolling colcon workspace- but I haven't run any tests beyond that.

If this works in 20.04 noetic also then there's no reason to have a humble branch?

[lucasw]

Now I'm not sure about 70f8064, I wasn't able to build in a catkin devel environment unless I also change the project name from LAS_VEGAS to lvr2, and make find_package LVR2 lowercase lvr2 in hdf5_map_io/CMakeLists.txt and mesh_msgs_conversions/CMakeLists.txt - even then it's still failing out with fatal error: H5Tpublic.h: No such file or directory

[amock]

Hi @lucasw,

if its possible to have it running independently of the ROS-distribution, it would be a reasonable change and we indeed would not need a humble branch anymore. I am a bit concerned that if it's not working we will have to start creating branches for each combination of ROS1-ROS2 distributions. But I would suggest we first go for it and if we notice problems we can start to think again :D

I would appreciate if you come up with a solution to that. Before merging everything into the main branch (or one shared branch) I would run the following tests:

For Ubuntu 20.04, Ubuntu 22.04 do

• Standard CMake project
  • Compile & Install with Cmake/make
  • Run examples
  • Check if mesh_tools are compiling and running

For Ubuntu 20.04 do

• ROS1 noetic
  • Place into ROS workspace
  • Compile
  • Check if mesh_tools are compiling and running

For Ubuntu 22.04 do

• ROS2 humble
  • Place into ROS workspace
  • Compile
  • Check if mesh_tools are compiling and running

I was also thinking about adding some Github-Workflows to automatically doing those tests. Thanks for contributing, let me know if you are making some progress.

[amock]

In PR #19 I replaced the build tool ament_cmake with cmake. This also resulted in lvr2 (humble branch) could be compiled with ROS1 noetic and Ubuntu 20 as well. I have not run any tests other than compiling. However, like this we could avoid the use of conditionals completely.

[lucasw]

That's compiling for me locally as well (along with mesh_tools packages that depend on it), and I'm setting this humble as the default elsewhere for some ros1 builds (lucasw/ros_from_src@6b46291)