Move emitRef from Verilog to backend #487
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed seemily redundant nameAll as called further down; Not passing tests as emitRef is called twice in some situations; Valid code is generated but does not start at T0
|
I've tried to incorporate these suggestions (and simplify naming - generate names once during nameAll()). Please check branch pr487. |
|
I don't think T and C should have equivalence. Looking at src/test/resources/MultiClockSuite_Comp_1.v, this verilog is actually unsynthesizable as T0 is used for clock and temporary variable but passes the test. |
|
There is interaction between this change and multi-word literals in the C++ backend. I think we need to visit all clients of emitIndex and verify consistent usage (possibly forcing everyone to use Backend.emitRef). |
|
Can one of the admins verify this patch? |
Conflicts: src/main/scala/Backend.scala
Conflicts: src/main/scala/Backend.scala
Don't use T0 for both clock and wire.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently not passing the tests as for some test cases are named twice and hence index does not start at 0.
Not sure where this is happening, but seems like it shouldn't be. Any suggestions on where to look?