FIX Don't call done unless the test case passes #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem:
Test case 'Reuse authentication tokens'
-> 'When a PEP Proxy has an expired token and another
request arrives to the proxy'
-> 'both requests should finish'
We call done() without being sure that both requests have finished.
Solution:
Only call done once the second request receives a response.
When the test case fails, it now does so in the test case proper
rather than in a hook.
|
The "once response is received" callbacks are identical. Perhaps we should extract that functionality into a separate function. |
|
LGTM. Concerning the duplicated code, you can add a technical debt issue in the issues list, and we will try to clean it once we have a slot to reduce techdebt. Thanks for your contribution. |
|
Added issue #341. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
In test case:
'Reuse authentication tokens'
-> 'When a PEP Proxy has an expired token and another
request arrives to the proxy'
-> 'both requests should finish'
We call done() without being sure that both requests have finished.
Solution:
Only call done once the second request receives a response.
When the test case fails, it now does so in the test case proper
rather than in the afterEach hook.