Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Don't call done unless the test case passes #339

Merged
merged 1 commit into from
Oct 19, 2016
Merged

FIX Don't call done unless the test case passes #339

merged 1 commit into from
Oct 19, 2016

Commits on Oct 14, 2016

  1. FIX Don't call done unless the test case passes 

    Problem:
Test case 'Reuse authentication tokens'
            -> 'When a PEP Proxy has an expired token and another
                request arrives to the proxy'
               -> 'both requests should finish'

We call done() without being sure that both requests have finished.

Solution:
Only call done once the second request receives a response.
When the test case fails, it now does so in the test case proper
rather than in a hook.
    @davisjam
    davisjam committed Oct 14, 2016
    Configuration menu
    Copy the full SHA
    3b535ba View commit details
    Browse the repository at this point in the history