Merge pull request #339 from davisjam/honest_done

FIX Don't call done unless the test case passes
telefonicaid · Oct 19, 2016 · 53843ac · 53843ac
2 parents a38ca63 + 3b535ba
commit 53843ac
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/test/unit/reuse_keystone_tokens_test.js b/test/unit/reuse_keystone_tokens_test.js
@@ -276,6 +276,9 @@ describe('Reuse authentication tokens', function() {
         it('both requests should finish', function(done) {
             var bus = new EventEmitter();
 
+            var nRequests = 2;
+            var nFinishedRequests = 0;
+
             mockOAuthApp.handler = function(req, res) {
                 if (req.path === currentAuthentication.authPath && req.method === 'POST') {
                     bus.once('secondArrived', function() {
@@ -300,7 +303,10 @@ describe('Reuse authentication tokens', function() {
             bus.once('firstWaiting', function() {
                 request(options, function(error, response, body) {
                     should.not.exist(error);
-                    done();
+                    nFinishedRequests++;
+                    if (nFinishedRequests === nRequests) {
+                      done();
+                    }
                 });
 
                 setTimeout(function() {
@@ -310,6 +316,10 @@ describe('Reuse authentication tokens', function() {
 
             request(options, function(error, response, body) {
                 should.not.exist(error);
+                nFinishedRequests++;
+                if (nFinishedRequests === nRequests) {
+                  done();
+                }
             });
         });
     });