Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request for generalizability templates #44

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Michael-Sun
Copy link

Study generalizability templates generated for:
fmriprepgr
generate_pdf
boldcorrelation/qc01_saveniinumpy
boldcorrelation/qc01_SLURM
boldcorrelation/qc02_SLURM
fdmean/fdmean_painruns
fdmean/fdmean_SUBMIT

@yarikoptic
Copy link
Collaborator

why to commit all the logs from all the jobs? did you look at the diff for the commits?

@Michael-Sun
Copy link
Author

Michael-Sun commented Aug 7, 2023

why to commit all the logs from all the jobs? did you look at the diff for the commits?

Good catch! So there are a number of logs to consider here, there are remnants of datalad, fmriprep, and mriqc that were probably committed and leftover by @jungheejung. I think those should be deleted and I have removed them from my branch, but she'll make the ultimate decision about whether or not to leave it in master. Then there are wasabi_physio logs that were left in there by me, which have now been removed.

@Michael-Sun
Copy link
Author

@yarikoptic I'm noticing that the current pull-request includes 7 commits that are relevant for the WASABI project but not for Spacetop, and only the latest commit is relevant for Spacetop. How should I go about completing this pull request, should I do git cherry-pick?

@yarikoptic
Copy link
Collaborator

you can cherry-pick into a new branch or if you just want to discard some but not the other in this branch, can do interactive rebase like git rebase -i HEAD~7 and leave only the one(s) you want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants