Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce space between name and address #2239

Merged
merged 3 commits into from
Jul 6, 2023
Merged

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Jul 6, 2023

What it solves

Unclear spacing

How this PR fixes it

This reduces the margin between the address and name (if it exists) within the transaction details for clarity.

How to test it

Ensure an address is in the address book and create a transaction to that address. Observe the reduced margin between the name/address.

Screenshots

image

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook requested a review from usame-algan July 6, 2023 09:18
@iamacook iamacook self-assigned this Jul 6, 2023
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Branch preview

✅ Deploy successful!

https://address_spacing--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Comment on lines 30 to 32
.address > div > div > div:nth-child(2) {
margin-top: -4px;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works but we need to keep in mind that it highly depends on the structure of EthHashInfo. As an alternative we could also decrease the line-height of the first child although its not as effective but assumes less of the structure e.g.

.address > div {
  line-height: 1;
}

@liliiaorlenko did we consider also increasing the spacing between each row like this (4px)?
Screenshot 2023-07-06 at 15 43 00

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep looks good!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the suggestion, I've implemented this.

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get this PR. You're moving the address up if it has a name? I thought the idea was to space them out, i.e. push items in the ABI arguments away from each other, not closer.

Also not a fan of the > div > div thing.

@iamacook
Copy link
Member Author

iamacook commented Jul 6, 2023

I don't get this PR. You're moving the address up if it has a name? I thought the idea was to space them out, i.e. push items in the ABI arguments away from each other, not closer.

Also not a fan of the > div > div thing.

As per discussion, I've opted for the line-height suggestion above.

@iamacook iamacook merged commit 28bffa5 into epic-tx-flow Jul 6, 2023
6 of 7 checks passed
@iamacook iamacook deleted the address-spacing branch July 6, 2023 15:31
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants