-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reduce space between name and address #2239
Conversation
Branch preview✅ Deploy successful! https://address_spacing--walletweb.review-wallet-web.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
.address > div > div > div:nth-child(2) { | ||
margin-top: -4px; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works but we need to keep in mind that it highly depends on the structure of EthHashInfo. As an alternative we could also decrease the line-height of the first child although its not as effective but assumes less of the structure e.g.
.address > div {
line-height: 1;
}
@liliiaorlenko did we consider also increasing the spacing between each row like this (4px)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the suggestion, I've implemented this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get this PR. You're moving the address up if it has a name? I thought the idea was to space them out, i.e. push items in the ABI arguments away from each other, not closer.
Also not a fan of the > div > div thing.
As per discussion, I've opted for the |
What it solves
Unclear spacing
How this PR fixes it
This reduces the margin between the address and name (if it exists) within the transaction details for clarity.
How to test it
Ensure an address is in the address book and create a transaction to that address. Observe the reduced margin between the name/address.
Screenshots
Checklist