Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce space between name and address #2239

Merged
merged 3 commits into from
Jul 6, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { Typography } from '@mui/material'
import { hexDataLength } from 'ethers/lib/utils'
import type { ReactElement, ReactNode } from 'react'
import css from './styles.module.css'
import valueCss from '@/components/transactions/TxDetails/TxData/DecodedData/Value/styles.module.css'
import EthHashInfo from '@/components/common/EthHashInfo'

type TxDataRowProps = {
Expand Down Expand Up @@ -31,7 +32,11 @@ export const generateDataRowValue = (
switch (type) {
case 'hash':
case 'address':
return <EthHashInfo address={value} hasExplorer={hasExplorer} showAvatar={false} showCopyButton />
return (
<div className={valueCss.address}>
<EthHashInfo address={value} hasExplorer={hasExplorer} showAvatar={false} showCopyButton />
</div>
)
case 'rawData':
return (
<div className={css.rawData}>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,9 @@ export const Value = ({ type, value, ...props }: ValueArrayProps): ReactElement
return <Value key={key} {...newProps} />
}
return (
<EthHashInfo
key={`${address}_${key}`}
address={address}
showAvatar={false}
shortAddress={false}
showCopyButton
hasExplorer
/>
<div key={`${address}_${key}`} className={css.address}>
<EthHashInfo address={address} showAvatar={false} shortAddress={false} showCopyButton hasExplorer />
</div>
)
})}
</div>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
.nestedWrapper {
padding-left: 12px;
}

/* Reduce space between name/address for clarity between rows */
.address > div {
line-height: 1;
}
Loading