Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reduce space between name and address #2239

Merged
merged 3 commits into from
Jul 6, 2023
Merged

fix: reduce space between name and address #2239

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
049cccf
fix: reduce space between name and address
iamacook Jul 6, 2023
32f0ee9
fix: adjust `line-height`
iamacook Jul 6, 2023
10c9994
fix: import
iamacook Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/components/transactions/TxDetails/Summary/TxDataRow/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,11 @@ export const generateDataRowValue = (
switch (type) {
case 'hash':
case 'address':
return <EthHashInfo address={value} hasExplorer={hasExplorer} showAvatar={false} showCopyButton />
return (
<div className={css.address}>
<EthHashInfo address={value} hasExplorer={hasExplorer} showAvatar={false} showCopyButton />
</div>
)
case 'rawData':
return (
<div className={css.rawData}>
Expand Down
5 changes: 5 additions & 0 deletions src/components/transactions/TxDetails/Summary/TxDataRow/styles.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@
align-items: center;
}

/* 2nd only exists if there is address book entry */
.address > div > div > div:nth-child(2) {
margin-top: -4px;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works but we need to keep in mind that it highly depends on the structure of EthHashInfo. As an alternative we could also decrease the line-height of the first child although its not as effective but assumes less of the structure e.g.

.address > div {
  line-height: 1;
}

@liliiaorlenko did we consider also increasing the spacing between each row like this (4px)?
Screenshot 2023-07-06 at 15 43 00

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep looks good!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the suggestion, I've implemented this.


@media (max-width: 599.95px) {
.gridRow {
grid-template-columns: 1fr;
Expand Down
Loading