Remove the check api infrastructure #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
07-31-rm-check-api
branch
from
eb49666
to
3f9963e
Compare
Turns out the check api stuff did not perform as we had hoped, remove the script and all the output files.
tcharding
force-pushed
the
07-31-rm-check-api
branch
from
3f9963e
to
0fc2533
Compare
apoelstra
approved these changes
Jul 31, 2024
|
@clarkmoody can we have a concept ACK on this before merging? |
clarkmoody
approved these changes
Aug 2, 2024
|
Merge when you get a chance please @apoelstra. |
apoelstra
added a commit
that referenced
this pull request
Aug 6, 2024
7bdabff Remove unused generic (Tobin C. Harding) Pull request description: Just patch 2, draft until #192 goes in. Turns out `clippy` does not warn for unused generics. Fix: #191 ACKs for top commit: apoelstra: ACK 7bdabff successfully ran local tests; note that this is technically a breaking change Tree-SHA512: 42fe88f886f053eaf6d68128cee9cb0f20a94afdd46dfca7bc2326726a9c2a6d010905ee97f1d2c0f13bcf620acfba1cb5463a48989c5e88f580def22ee9e5da
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out the check api stuff did not perform as we had hoped, remove the script and all the output files.