-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional dependency on ordering crate #190
Conversation
Requested by lightningdevkit/rust-lightning#3195 |
Something is wrong with the check api script, @apoelstra now that we removed it in |
Yeah, let's remove it everywhere. These constant breakages I think are unacceptable given the way we were trying to use it. I also never got it to work with my local CI so we never really integrated it that well. |
utACK a8ceeb6 but the check-API commit should be changed to just remove the script. |
0689320
to
0e9d4e7
Compare
523b6c6
to
e7bcc93
Compare
Add an optional dependency on the `ordering` crate and implement `ArbitraryOrd` for `Fe32` if the feature is enabled.
e7bcc93
to
64b3995
Compare
Rebase only, no code changes. |
FWIW I'm increasingly skeptical of this. It's not clear that anybody needs it and it increases our feature test matrix. |
I'll close since you are looking into the |
Add an optional dependency on the
ordering
crate and implementArbitraryOrd
forFe32
if the feature is enabled.