Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the check api infrastructure #192

Merged
merged 1 commit into from
Aug 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -140,18 +140,3 @@ jobs:
run: cargo install cross --locked
- name: run cross test
run: cross test --target s390x-unknown-linux-gnu

API:
name: Check for changes to the public API
runs-on: ubuntu-latest
strategy:
fail-fast: false
steps:
- name: Checkout Crate
uses: actions/checkout@v3
- name: Checkout Toolchain
uses: dtolnay/rust-toolchain@nightly
- name: Install cargo-public-api
run: cargo install --locked cargo-public-api
- name: Running API checker script
run: ./contrib/check-for-api-changes.sh
7 changes: 0 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,3 @@ Alternatively add symlinks in your `.git/hooks` directory to any of the githooks

We use a custom Rust compiler configuration conditional to guard the benchmark code. To run the
benchmarks use: `RUSTFLAGS='--cfg=bench' cargo +nightly bench`.


## API changes

All PRs that change the public API of `rust-bech32` must include a patch to the
`api/` text files. For PRs that include API changes, add a separate patch to the PR
that is the diff created by running `contrib/check-for-api-changes.sh`.
11 changes: 0 additions & 11 deletions api/README.md

This file was deleted.

1,278 changes: 0 additions & 1,278 deletions api/all-features.txt

This file was deleted.

1,220 changes: 0 additions & 1,220 deletions api/alloc-only.txt

This file was deleted.

1,133 changes: 0 additions & 1,133 deletions api/no-features.txt

This file was deleted.

63 changes: 0 additions & 63 deletions contrib/check-for-api-changes.sh

This file was deleted.

4 changes: 0 additions & 4 deletions justfile
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,3 @@ clippy:
# run `cargo clippy --fix` on everything
clippy-fix:
cargo clippy --locked --offline --workspace --all-targets --fix

# Check for API changes.
check-api:
contrib/check-for-api-changes.sh
Loading