Fix up two different C problems. #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first one was that the visibility_control file was marked as a C++ header, but was included in a C header. Avoid that by just making visibility_control a C header. The second problem is that, in C, a function with no arguments technically takes "any" arguments. Fix ros_trace_compile_status() to have void arguments, which ensures that no arguments can be passed. Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
clalancette
force-pushed
the
clalancette/fix-visibility-control
branch
from
c5e880c
to
06abd59
Compare
christophebedard
approved these changes
Aug 2, 2024
|
CI:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first one was that the visibility_control file was marked as a C++ header, but was included in a C header. Avoid that by just making visibility_control a C header.
The second problem is that, in C, a function with no arguments technically takes "any" arguments. Fix
ros_trace_compile_status() to have void arguments, which ensures that no arguments can be passed.
This might have an effect on some Clang warnings that we see in e.g. https://ci.ros2.org/view/nightly/job/nightly_linux_clang_libcxx/1968/gcc/new/ , but regardless this is more correct.