Fix up two different C problems. (#129)

* Fix up two different C problems. The first one was that the visibility_control file was marked as a C++ header, but was included in a C header. Avoid that by just making visibility_control a C header. The second problem is that, in C, a function with no arguments technically takes "any" arguments. Fix ros_trace_compile_status() to have void arguments, which ensures that no arguments can be passed. Signed-off-by: Chris Lalancette <[email protected]>
ros2 · Aug 2, 2024 · 7758ad4 · 7758ad4
1 parent 409ae64
commit 7758ad4
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/tracetools/CMakeLists.txt b/tracetools/CMakeLists.txt
@@ -50,7 +50,7 @@ set(SOURCES
 set(HEADERS
   include/${PROJECT_NAME}/tracetools.h
   include/${PROJECT_NAME}/utils.hpp
-  include/${PROJECT_NAME}/visibility_control.hpp
+  include/${PROJECT_NAME}/visibility_control.h
 )
 if(NOT TRACETOOLS_TRACEPOINTS_EXCLUDED)
   # We only need these if we're using LTTng

diff --git a/tracetools/include/tracetools/tracetools.h b/tracetools/include/tracetools/tracetools.h
@@ -32,7 +32,7 @@
 #include <stdbool.h>
 
 #include "tracetools/config.h"
-#include "tracetools/visibility_control.hpp"
+#include "tracetools/visibility_control.h"
 
 #ifndef TRACETOOLS_DISABLED
 /**
@@ -134,7 +134,7 @@ extern "C"
 /**
  * \return `true` if tracing is enabled, `false` otherwise
  */
-TRACETOOLS_PUBLIC bool ros_trace_compile_status();
+TRACETOOLS_PUBLIC bool ros_trace_compile_status(void);
 
 /// `rcl_init`
 /**

diff --git a/...include/tracetools/visibility_control.hpp → ...s/include/tracetools/visibility_control.h b/...include/tracetools/visibility_control.hpp → ...s/include/tracetools/visibility_control.h
@@ -19,8 +19,8 @@
  * library cannot have, but the consuming code must have inorder to link.
  */
 
-#ifndef TRACETOOLS__VISIBILITY_CONTROL_HPP_
-#define TRACETOOLS__VISIBILITY_CONTROL_HPP_
+#ifndef TRACETOOLS__VISIBILITY_CONTROL_H_
+#define TRACETOOLS__VISIBILITY_CONTROL_H_
 
 // This logic was borrowed (then namespaced) from the examples on the gcc wiki:
 //     https://gcc.gnu.org/wiki/Visibility
@@ -53,4 +53,4 @@
   #define TRACETOOLS_PUBLIC_TYPE
 #endif
 
-#endif  // TRACETOOLS__VISIBILITY_CONTROL_HPP_
+#endif  // TRACETOOLS__VISIBILITY_CONTROL_H_
diff --git a/tracetools/src/tracetools.c b/tracetools/src/tracetools.c
@@ -68,7 +68,7 @@
   }
 // *INDENT-ON*
 
-bool ros_trace_compile_status()
+bool ros_trace_compile_status(void)
 {
 #ifndef TRACETOOLS_TRACEPOINTS_EXCLUDED
   return true;