Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(main): --packages-select and --packages-skip #907

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Guillaumebeuzeboc
Copy link

@Guillaumebeuzeboc Guillaumebeuzeboc commented Nov 22, 2022

Hello,
With this feature, I added options to only process or skip packages like colcon can do.
Rosdep already support COLCON_IGNORE and CATKIN_IGNORE, but with these flags no need to manually place those files.

This way, we can run rosdep over ros2 demos and ignore only a few examples.
Example:

git clone https://github.com/ros2/demos.git
cd demos
rosdep install --default-yes --ignore-packages-from-source -s --from-paths . --packages-skip "lifecycle lifecycle_py"

Add options to only process or skip packages like
colcon can do.
Rosdep already support COLCON_IGNORE and CATKIN_IGNORE
but with these flags no need to manually place those files
@artivis
Copy link
Contributor

artivis commented Nov 23, 2022

Hi @cottsay, could we get an approval for the ci workflow to run please?

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2022

Codecov Report

Base: 74.83% // Head: 74.85% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (ada7472) compared to base (b6ad189).
Patch coverage: 83.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #907      +/-   ##
==========================================
+ Coverage   74.83%   74.85%   +0.02%     
==========================================
  Files          44       44              
  Lines        3362     3373      +11     
==========================================
+ Hits         2516     2525       +9     
- Misses        846      848       +2     
Impacted Files Coverage Δ
src/rosdep2/main.py 49.23% <83.33%> (+0.62%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants