Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some reorganizations in the chapter. #404

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

jb-brelot-nxp
Copy link
Collaborator

THe idea is to move any chapter relative to ABI to Appendix

@jb-brelot-nxp jb-brelot-nxp changed the title Make some reorganizations in the chapeter. Make some reorganizations in the chapter. Sep 6, 2024
@james-ball-qualcomm
Copy link
Collaborator

Can we move chapters 3 & 4 (M-mode and S-mode CSRs for configuring CLIC) under chapters 5 & 6 (smclic and ssclic respectively)? We could have a heading in smclic/ssclic for direct CSRs and another for indirect CSRs. Seems strange that the smclic and ssclic chapters that list CSRs in their privilege mode don't include all their CSRs. I'm guessing the current organization is an artifact of having memory-mapped configuration in older CLIC versions.

@christian-herber-nxp
Copy link
Collaborator

Update the change log

@jb-brelot-nxp
Copy link
Collaborator Author

Updated version of the pull request :
chapter 3 and 4 have been moved
chapter 11 is transformed as a NOTE in 5.5
Moving chapter 12 in appendix
Remove "Appendix :" typo

Copy link
Collaborator

@christian-herber-nxp christian-herber-nxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

src/clic.adoc Outdated Show resolved Hide resolved
Copy link
Collaborator

@james-ball-qualcomm james-ball-qualcomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested some changes to the indirect access CSR heading title.
Can we make parallel naming changes to the CSRs that we already in the smclic/ssclic chapters? Namely that would be change "CLIC CSRs" to "Direct Access M-mode CSRs" (in smclic chapter) and "Direct Access S-mode CSRs" (in ssclic chapter).

src/clic.adoc Outdated Show resolved Hide resolved
src/clic.adoc Outdated Show resolved Hide resolved
src/clic.adoc Show resolved Hide resolved
jb-brelot-nxp and others added 2 commits September 12, 2024 09:33
Co-authored-by: Christian Herber <[email protected]>
Signed-off-by: jb-brelot-nxp <[email protected]>
Co-authored-by: Christian Herber <[email protected]>
Signed-off-by: jb-brelot-nxp <[email protected]>
@christian-herber-nxp christian-herber-nxp merged commit 07c3138 into master Sep 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interrupt ID ordering recommendations
3 participants