-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make some reorganizations in the chapter. #404
Conversation
…ng from ABI to appendix
Can we move chapters 3 & 4 (M-mode and S-mode CSRs for configuring CLIC) under chapters 5 & 6 (smclic and ssclic respectively)? We could have a heading in smclic/ssclic for direct CSRs and another for indirect CSRs. Seems strange that the smclic and ssclic chapters that list CSRs in their privilege mode don't include all their CSRs. I'm guessing the current organization is an artifact of having memory-mapped configuration in older CLIC versions. |
Update the change log |
Updated version of the pull request : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested some changes to the indirect access CSR heading title.
Can we make parallel naming changes to the CSRs that we already in the smclic/ssclic chapters? Namely that would be change "CLIC CSRs" to "Direct Access M-mode CSRs" (in smclic chapter) and "Direct Access S-mode CSRs" (in ssclic chapter).
Co-authored-by: Christian Herber <[email protected]> Signed-off-by: jb-brelot-nxp <[email protected]>
Co-authored-by: Christian Herber <[email protected]> Signed-off-by: jb-brelot-nxp <[email protected]>
THe idea is to move any chapter relative to ABI to Appendix