Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Xbitmanip instructions #1384

Merged
merged 5 commits into from
Jun 18, 2023
Merged

Remove Xbitmanip instructions #1384

merged 5 commits into from
Jun 18, 2023

Conversation

aswaterman
Copy link
Collaborator

This change is motivated by the fact that Zicond extension support is broken, as pointed out in riscvarchive/riscv-zicond#12, because the ratified Zicond opcodes overlap the unratified Zbt opcode for CMOV.

We gave the unratified bitmanip instructions a two-year grace period in Spike, which I think was generous. And when some of these instructions are eventually revived, their implementation can be found in the git history.

@aswaterman aswaterman merged commit 7e50839 into master Jun 18, 2023
3 checks passed
@aswaterman aswaterman deleted the remove-xbitmanip branch June 18, 2023 16:16
@ptomsich
Copy link
Collaborator

I'll follow this up with a disasm.cc change to correctly recognize the czero.{eqz.nez}, as that had been missed on the original submission.

@aswaterman
Copy link
Collaborator Author

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants