Fix uml permissions #913
Merged
Fix uml permissions #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #913 +/- ##
=======================================
Coverage 94.58% 94.58%
=======================================
Files 33 33
Lines 3378 3378
=======================================
Hits 3195 3195
Misses 183 183 ☔ View full report in Codecov by Sentry. |
wd60622
commented
Aug 5, 2024
.github/workflows/uml.yml
Outdated
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| permissions: write-all | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v2 |
There was a problem hiding this comment.
Will try v4 instead
Also, make sure that the checked out hash is good to push and doesnt require additional pull
juanitorduz
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Let’s try it out on main and if fails we revert ok @wd60622 😄?
|
Think we have a winner @juanitorduz 🎉 |
|
Yay! Thanks for going into this rabbit whole 😅 |
radiokosmos
pushed a commit
to radiokosmos/pymc-marketing
that referenced
this pull request
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Checklist
Modules affected
Type of change
📚 Documentation preview 📚: https://pymc-marketing--913.org.readthedocs.build/en/913/