Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uml permissions #913

Merged
merged 9 commits into from
Aug 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/uml.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@ on:
paths:
- "pymc_marketing/**"

permissions: write-all

jobs:
build:
runs-on: ubuntu-latest

permissions: write-all
steps:
- name: Checkout repository
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
ref: ${{ github.head_ref || 'main' }}

- name: Set up Python
uses: actions/setup-python@v2
Expand All @@ -43,7 +43,7 @@ jobs:
else
echo "Committing the changes"
git commit -m "Update UML Diagrams"
git push origin HEAD:${GITHUB_HEAD_REF}
git push origin HEAD:${GITHUB_HEAD_REF:-main}
fi
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Binary file modified docs/source/uml/classes_mmm.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 2 additions & 0 deletions pymc_marketing/mmm/lift_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@


class MissingLiftTestError(Exception):
"""Error when some of the lift tests are not in the model."""

def __init__(self, missing_values: npt.NDArray[np.int_]) -> None:
self.missing_values = missing_values
super().__init__(
Expand Down
Loading