Fix uml permissions (pymc-labs#913)

radiokosmos · Sep 1, 2024 · 307a45c · 307a45c
1 parent b867191
commit 307a45c
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/.github/workflows/uml.yml b/.github/workflows/uml.yml
@@ -10,15 +10,15 @@ on:
     paths:
       - "pymc_marketing/**"
 
-permissions: write-all
-
 jobs:
   build:
     runs-on: ubuntu-latest
-
+    permissions: write-all
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
+        with:
+          ref: ${{ github.head_ref || 'main' }}
 
       - name: Set up Python
         uses: actions/setup-python@v2
@@ -43,7 +43,7 @@ jobs:
           else
             echo "Committing the changes"
             git commit -m "Update UML Diagrams"
-            git push origin HEAD:${GITHUB_HEAD_REF}
+            git push origin HEAD:${GITHUB_HEAD_REF:-main}
           fi
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
diff --git a/docs/source/uml/classes_mmm.png b/docs/source/uml/classes_mmm.png
diff --git a/pymc_marketing/mmm/lift_test.py b/pymc_marketing/mmm/lift_test.py
@@ -27,6 +27,8 @@
 
 
 class MissingLiftTestError(Exception):
+    """Error when some of the lift tests are not in the model."""
+
     def __init__(self, missing_values: npt.NDArray[np.int_]) -> None:
         self.missing_values = missing_values
         super().__init__(