Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clean and fix console warnings #33601

Merged
merged 8 commits into from
Nov 6, 2023
Merged

chore: clean and fix console warnings #33601

merged 8 commits into from
Nov 6, 2023

Conversation

DanielVZ96
Copy link
Contributor

Description

This warning are appearing too many times during provisioning. They clutter logs and hinder dev experience (#32888).

Changes:

Useful information to include:

  • Which edX user roles will this change impact? Common user roles are "Learner", "Course Author",
    "Developer", and "Operator".
  • Include screenshots for changes to the UI (ideally, both "before" and "after" screenshots, if applicable).
  • Provide links to the description of corresponding configuration changes. Remember to correctly annotate these
    changes.

Testing instructions

Please provide detailed step-by-step instructions for testing this change.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 26, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 26, 2023 •
edited
Loading

Thanks for the pull request, @DanielVZ96! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@DanielVZ96 DanielVZ96 mentioned this pull request Oct 26, 2023
Closed
@DanielVZ96 DanielVZ96 marked this pull request as ready for review October 26, 2023 01:55
Agrendalath
Agrendalath requested changes Oct 26, 2023
View reviewed changes
xmodule/modulestore/store_utilities.py Outdated Show resolved Hide resolved
cms/pytest.ini Outdated Show resolved Hide resolved
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 26, 2023
Agrendalath
Agrendalath requested changes Oct 27, 2023
View reviewed changes
cms/pytest.ini Outdated Show resolved Hide resolved
openedx/core/lib/logsettings.py Outdated Show resolved Hide resolved
openedx/core/lib/logsettings.py Outdated Show resolved Hide resolved
cms/pytest.ini Outdated Show resolved Hide resolved
@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 27, 2023
Agrendalath
Agrendalath reviewed Oct 30, 2023
View reviewed changes
openedx/core/lib/logsettings.py Outdated Show resolved Hide resolved
openedx/core/lib/logsettings.py Outdated Show resolved Hide resolved
cms/pytest.ini Outdated Show resolved Hide resolved
Agrendalath
Agrendalath reviewed Oct 31, 2023
View reviewed changes
Copy link
Member

@Agrendalath Agrendalath left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanielVZ96, this looks good to merge once the last CI issue is resolved (I described the fix in #33601 (comment)). As the review is complete, please rebase your commits to include changes from 7cfeb96e9a48ba8e9590768a2630842978e039a4 in specific commits.

cms/pytest.ini Outdated
@@ -12,6 +12,17 @@ filterwarnings =
default
ignore:No request passed to the backend, unable to rate-limit:UserWarning
ignore::xblock.exceptions.FieldDataDeprecationWarning
# Remove next two default_app_config warnings after updating Django to 4.2
ignore:.*You can remove default_app_config.*:PendingDeprecationWarning
ignore:.*You can remove default_app_config.*:django.utils.deprecation.RemovedInDjango41Warning
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly, RemovedInDjango41Warning is a subclass of PendingDeprecationWarning in Django 3.2 (and a subclass of the DeprecationWarning in Django <4.2, but we don't use this version). Specifying PendingDeprecationWarning should be enough.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree, i actually had this removed but forgot to commit it. will do so with the rebase

@DanielVZ96 DanielVZ96 requested a review from a team as a code owner November 1, 2023 03:15
@DanielVZ96 DanielVZ96 force-pushed the dvz/clean-warnings branch 2 times, most recently from 828954b to 2b11481 Compare November 1, 2023 03:18
@DanielVZ96
chore: ignore default_app_config warning
66c5be8 
related issue: openedx#33572
@DanielVZ96
chore: ignore HTTPResponse.getheaders() deprecation warning
d2f427a 
related issue: openedx#33584

note: this warning is rased from a third party library (elasticsearch)
@DanielVZ96
chore: ignore import ABCs from 'collections' warning
ef0a9c0 
related issue: openedx#33584

note: this warning is from a third party library (libsass)
@DanielVZ96
chore: replace newrelic add_custom_parameter deprecated method
72be481 
related issue: openedx#33584

note: it has been replaced with add_custom_attribute. it is just a rename
https://docs.newrelic.com/docs/release-notes/agent-release-notes/python-release-notes/python-agent-80300/
@DanielVZ96
fix: flags not at the start of the expression
115c65a 
related issue: openedx#33585
@DanielVZ96
chore: ignore warning from pkg_resources.declare_namespace
9752da2 
Related issue: openedx#33592
@DanielVZ96
chore: ignore 'etree' is deprecated
398c84e 
Related issue: openedx#32888
@DanielVZ96
Copy link
Contributor Author

@Agrendalath rebased and now the PR is ready for merge.

Agrendalath
Agrendalath approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@Agrendalath Agrendalath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: checked that the warnings are suppressed
  • I read through the code
  • I checked for accessibility issues: n/a
  • Includes documentation: n/a

@Agrendalath Agrendalath merged commit 2cf4d73 into openedx:master Nov 6, 2023
64 checks passed
@openedx-webhooks
Copy link

@DanielVZ96 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

This was referenced Nov 6, 2023
Closed
Open
Closed
Closed
Closed
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Agrendalath Agrendalath Agrendalath approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DanielVZ96 @openedx-webhooks @edx-pipeline-bot @Agrendalath @mphilbrick211 @Mashal-m