Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore default_app_config warning #33591

Conversation

DanielVZ96
Copy link
Contributor

Description

RemovedInDjango41Warning: 'webpack_loader' defines default_app_config = 'webpack_loader.apps.WebpackLoaderConfig'. Django now detects this configuration automatically. You can remove default_app_config.

This warning is appearing 29 times during provisioning. It clutters logs and hinders dev experience (#32888). It's coming from multiple dependencies, and it won't cause any mayor issue besides cluttering. Only one of those dependencies are openedx related, and I made a PR to fix the warning there: openedx/completion#259

Supporting information

Related Issues:

Testing instructions

  • on devstack run make dev.up.lms and make lms-shell
  • inside the shell run ./manage.py lms shell or ./manage.py cms shell
  • make sure there are no warnings containing You can remove default_app_config.

Deadline

None

@openedx-webhooks
Copy link

Thanks for the pull request, @DanielVZ96! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

⚠️ We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by adding a comment here that you have signed it. If the problem persists, you can tag the @openedx/cla-problems team in a comment on your PR for further assistance.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 25, 2023
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 25, 2023
@mphilbrick211
Copy link

Hi @DanielVZ96! Thank you for this contribution! Please let me know if you have any questions regarding submitting a CLA form.

Note, if you are not contributing as an individual, and are contributing on behalf of an organization, please let me know as the CLA process is a bit different in that case.

@DanielVZ96
Copy link
Contributor Author

hi @mphilbrick211, just signed! (i guess i'll have to wait now)

@DanielVZ96
Copy link
Contributor Author

closed in favor of #33601

@DanielVZ96 DanielVZ96 closed this Oct 26, 2023
@openedx-webhooks
Copy link

@DanielVZ96 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

1 similar comment
@openedx-webhooks
Copy link

@DanielVZ96 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants