Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Django now detects this configuration automatically. You can remove default_app_config. #33572

Closed
1 task
Tracked by #32888
DanielVZ96 opened this issue Oct 24, 2023 · 6 comments
Closed
1 task
Tracked by #32888

Comments

@DanielVZ96
Copy link
Contributor

This warning is appearing 29 times during provisioning. It clutters logs and hinders dev experience (#32888).

It's coming from multiple dependencies, but it won't cause any mayor issue besides cluttering.

AC

  • The warnings stop cluttering logs
@Agrendalath
Copy link
Member

@DanielVZ96, shouldn't this be "Fix" instead of "Ignore"?

@DanielVZ96 DanielVZ96 changed the title Ignore: Django now detects this configuration automatically. You can remove default_app_config. Fix: Django now detects this configuration automatically. You can remove default_app_config. Oct 24, 2023
@DanielVZ96
Copy link
Contributor Author

@Agrendalath I was considering just ignoring the issue since it's not critical and it comes from third party dependencies (django-webpack, pylti1.3, bridgekeeper)

@Agrendalath
Copy link
Member

@DanielVZ96, I see. If none of these warnings comes from the edx-platform or other related repos, we can ignore them.

@DanielVZ96
Copy link
Contributor Author

found one library from a related repo. Here's the PR: openedx/completion#259

@DanielVZ96
Copy link
Contributor Author

DanielVZ96 commented Oct 25, 2023

and here's the PR to ignore the warnings #33591

@DanielVZ96 DanielVZ96 changed the title Fix: Django now detects this configuration automatically. You can remove default_app_config. fix: Django now detects this configuration automatically. You can remove default_app_config. Oct 26, 2023
DanielVZ96 added a commit to DanielVZ96/edx-platform that referenced this issue Nov 1, 2023
@Agrendalath
Copy link
Member

Resolved by #33601.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants