-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not define django_app_config #259
fix: do not define django_app_config #259
Conversation
Thanks for the pull request, @DanielVZ96! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Hi @DanielVZ96! Thank you for this contribution! Please let me know if you have any questions regarding submitting a CLA form. Note, if you are not contributing as an individual, and are contributing on behalf of an organization, please let me know as the CLA process is a bit different in that case. |
completion/__init__.py
Outdated
if django.VERSION < (3, 2): | ||
default_app_config = 'completion.apps.CompletionAppConfig' # pylint: disable=invalid-name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We no longer need to support Django versions older than 3.2
.
@DanielVZ96 It also looks like there are some test failures that need attention. |
Hi @e0d, i'm already in the process to sign it. Had some linting issues and an issue with the format of the pytest.ini file. should be better now. i'm using https://github.com/nektos/act to run CI locally for now |
1ac827c
to
814319b
Compare
814319b
to
7d30f4e
Compare
7d30f4e
to
1222a4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- I tested this: checked that the warning is gone
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a
@pkulkark, would you like to review this as the CC? The only thing needed for testing this is checking that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DanielVZ96 @Agrendalath LGTM 👍. I verified that there were no RemovedInDjango41Warning
in any of the CI tests. I did notice a couple of RemovedInDjango51Warning
like this:
/home/runner/work/completion/completion/.tox/django42-drf314/lib/python3.8/site-packages/django/db/models/options.py:210: RemovedInDjango51Warning: 'index_together' is deprecated. Use 'Meta.indexes' in 'completion.BlockCompletion' instead.
But I suppose that'll be tackled when we upgrade to django 5.
@DanielVZ96 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description:
Newer django versions throw the following warning:
RemovedInDjango41Warning: 'completion' defines default_app_config = 'completion.apps.CompletionAppConfig'. Django now detects this configuration automatically. You can remove default_app_config.
, and it clutters edx-platform logs. This PR avoids defining it when django.VERSION < 3.2Related issue: openedx/edx-platform#33572
Installation instructions: List any non-trivial installation
instructions.
Testing instructions:
make install
pytest -k "DefaultAppConfig" --no-cov -v
and make suretest_not_defined
passesReviewers:
Merge checklist:
Post merge:
finished.