styleguide: tests goroutine leaks and naming #4348
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add rules to style guide to have more consistent test names and to increase their stability.
Rename tests that verifies concurrency safety to have
ConcurrentSafe
as suffix (I think I found most of them).internal/global: fix goroutine leaks in tests. Fixes Data race in internal/global/internal_logging.go #4264
Testing:
Next week, I plan to check if tests in other packages have the same problem
If requested I can split this to separate PR's. However, I think it may be easier to review everything at once as the code changes give context to the new rules introduced in the style guide.