Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdk/metric: Fix goroutine leaks in tests #4352

Merged
merged 7 commits into from
Jul 25, 2023
Merged

sdk/metric: Fix goroutine leaks in tests #4352

merged 7 commits into from
Jul 25, 2023

Conversation

pellared
Copy link
Member

@pellared pellared commented Jul 24, 2023 •
edited
Loading

Follows #4348:

Next week, I plan to check if tests in other packages have the same problem

@pellared pellared added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 24, 2023
@pellared pellared marked this pull request as ready for review July 24, 2023 09:10
MrAlias
MrAlias reviewed Jul 24, 2023
View reviewed changes
sdk/metric/cache_test.go Outdated Show resolved Hide resolved
@pellared pellared requested a review from MrAlias July 24, 2023 16:01
@pellared pellared merged commit d8d3502 into open-telemetry:main Jul 25, 2023
21 checks passed
@pellared pellared deleted the sdk-metric-fix-test-leaks branch July 25, 2023 08:54
@MrAlias MrAlias added this to the v1.17.0 milestone Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmathieu dmathieu dmathieu approved these changes

@dashpole dashpole dashpole approved these changes

@MrAlias MrAlias MrAlias approved these changes

@hanyuancheung hanyuancheung hanyuancheung approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v1.17.0/v0.40.0
Development

Successfully merging this pull request may close these issues.
5 participants
@pellared @dmathieu @dashpole @MrAlias @hanyuancheung