Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix goroutine leaks in tests #4098

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Fix goroutine leaks in tests #4098

merged 1 commit into from
Jul 25, 2023

Conversation

pellared
Copy link
Member

Follows open-telemetry/opentelemetry-go#4348:

Next week, I plan to check if tests in other packages have the same problem

@pellared pellared added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Jul 24, 2023
@pellared pellared marked this pull request as ready for review July 24, 2023 09:10
@pellared pellared requested a review from a team July 24, 2023 09:10
@pellared pellared merged commit 3061fc5 into open-telemetry:main Jul 25, 2023
22 of 23 checks passed
@pellared pellared deleted the test-leaks branch July 25, 2023 08:05
@MrAlias MrAlias added this to the v0.43.0 milestone Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmathieu dmathieu dmathieu approved these changes

@dashpole dashpole dashpole approved these changes

@MrAlias MrAlias MrAlias approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

Assignees
No one assigned
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Milestone
v0.43.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pellared @dmathieu @dashpole @MrAlias