Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Iteration related Events #3019

Closed
wants to merge 1 commit into from
Closed

Add Iteration related Events #3019

wants to merge 1 commit into from

Conversation

b-chu
Copy link
Contributor

@b-chu b-chu commented Feb 15, 2024 •
edited
Loading

What does this PR do?

Adds ITERATION_START, ITERATION_END, and ITERATION_CHECKPOINT to Event,
Engine, and Callback.

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

This was referenced Feb 15, 2024
Merged
Closed
Closed
@b-chu b-chu force-pushed the spr/dev/26924316 branch 2 times, most recently from dd3ed43 to 8e50819 Compare February 15, 2024 23:33
@b-chu b-chu force-pushed the spr/dev/5d87db4b branch 2 times, most recently from 4109fa9 to ff289ea Compare February 16, 2024 00:30
@b-chu b-chu force-pushed the spr/dev/26924316 branch 2 times, most recently from d173b20 to 2b2da38 Compare February 16, 2024 00:40
@b-chu b-chu force-pushed the spr/dev/5d87db4b branch 2 times, most recently from ce8f8ae to 70a4d88 Compare February 16, 2024 00:47
Base automatically changed from spr/dev/5d87db4b to dev February 27, 2024 18:08
@b-chu b-chu force-pushed the spr/dev/26924316 branch 2 times, most recently from f46c7c4 to f0375f8 Compare March 1, 2024 17:50
@b-chu b-chu changed the title Add Iteration Event Add Iteration related Events Mar 1, 2024
This was referenced Mar 1, 2024
Merged
Merged
@b-chu
Add Iteration related Events
d95bbd7 
Adds ITERATION_START, ITERATION_END, and ITERATION_CHECKPOINT to Event,
Engine, and Callback.

commit-id:26924316
@b-chu b-chu requested review from rajammanabrolu, bcui19, mvpatel2000 and a team March 1, 2024 21:12
@b-chu b-chu marked this pull request as ready for review March 1, 2024 21:12
@b-chu b-chu requested a review from snarayan21 March 1, 2024 21:24
mvpatel2000
mvpatel2000 reviewed Mar 4, 2024
View reviewed changes
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're missing adding it to trainer if you are going to add to docs. I would recommend one PR please given the change is relatively small and flattening things a bit

@b-chu
Copy link
Contributor Author

b-chu commented Mar 4, 2024

Closing pull request: commit has gone away

@b-chu b-chu closed this Mar 4, 2024
@b-chu
Copy link
Contributor Author

b-chu commented Mar 4, 2024

Flattening into #3076

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 left review comments

@rajammanabrolu rajammanabrolu Awaiting requested review from rajammanabrolu

@bcui19 bcui19 Awaiting requested review from bcui19

@snarayan21 snarayan21 Awaiting requested review from snarayan21

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@b-chu @mvpatel2000