Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iteration to TimeUnit #3013

Closed
wants to merge 1 commit into from
Closed

Add iteration to TimeUnit #3013

wants to merge 1 commit into from

Conversation

b-chu
Copy link
Contributor

@b-chu b-chu commented Feb 14, 2024

What does this PR do?

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@b-chu b-chu mentioned this pull request Feb 14, 2024
7 tasks
@b-chu b-chu changed the title Add duration to to_next_epoch Add iteration to TimeUnit Feb 14, 2024
@b-chu b-chu force-pushed the spr/dev/e4729f79 branch 2 times, most recently from 10fb3c1 to 6c35d51 Compare February 14, 2024 23:06
@b-chu b-chu force-pushed the spr/dev/5f8ef9be branch 2 times, most recently from 9784717 to 808d37d Compare February 14, 2024 23:46
@b-chu b-chu force-pushed the spr/dev/e4729f79 branch 6 times, most recently from 634cc1c to 33c2bca Compare February 15, 2024 19:34
@b-chu b-chu marked this pull request as ready for review February 15, 2024 20:12
Copy link
Contributor

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

composer/core/time.py Outdated Show resolved Hide resolved
composer/core/time.py Outdated Show resolved Hide resolved
composer/core/time.py Show resolved Hide resolved
composer/core/time.py Outdated Show resolved Hide resolved
composer/core/time.py Outdated Show resolved Hide resolved
Copy link
Contributor

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, lgtm

Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding per offline discussion

commit-id:e4729f79
@b-chu
Copy link
Contributor Author

b-chu commented Feb 27, 2024

✓ Commit merged in pull request #3017

@b-chu b-chu closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants