Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Iteration related Events #3076

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Add Iteration related Events #3076

merged 1 commit into from
Mar 5, 2024

Conversation

b-chu
Copy link
Contributor

@b-chu b-chu commented Mar 1, 2024

What does this PR do?

Adds ITERATION_START, ITERATION_END, and ITERATION_CHECKPOINT to Event, Engine, and Callback. Increments iteration during training based on iteration length defined in State. Iteration length is a private variable in State and should have no effect by default.

commit-id:bdbe33f2


Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@b-chu b-chu force-pushed the spr/dev/bdbe33f2 branch 2 times, most recently from 1ae12d5 to 9b0a8b0 Compare March 1, 2024 20:09
@b-chu b-chu force-pushed the spr/dev/bdbe33f2 branch 2 times, most recently from 056afc3 to a46990c Compare March 1, 2024 20:28
@b-chu b-chu marked this pull request as ready for review March 1, 2024 21:12
@b-chu b-chu changed the title Add Iteration to training loop Add Iteration related Events Mar 4, 2024
@b-chu b-chu changed the base branch from spr/dev/26924316 to dev March 4, 2024 17:21
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add some tests that run multiple iterations? Ideally we have a test that also tries changing iteration length and tests new API in state

Adds ITERATION_START, ITERATION_END, and ITERATION_CHECKPOINT to Event, Engine, and Callback. Increments iteration during training based on iteration length defined in State. Iteration length is a private variable in State and should have no effect by default.

commit-id:bdbe33f2
@bcui19
Copy link
Contributor

bcui19 commented Mar 4, 2024

From my perspective, this seems good. Added some comments, but yea it'd be good to add more testing/also include tests on if we have early breaks from an epoch in an iteration.

@b-chu b-chu merged commit 7631c99 into dev Mar 5, 2024
14 checks passed
@b-chu b-chu deleted the spr/dev/bdbe33f2 branch March 5, 2024 17:46
@b-chu
Copy link
Contributor Author

b-chu commented Mar 5, 2024

For early breaks in iteration, this would be implemented by users via callback so wouldn't be tested here

j316chuck pushed a commit that referenced this pull request Mar 29, 2024
Adds ITERATION_START, ITERATION_END, and ITERATION_CHECKPOINT to Event, Engine, and Callback. Increments iteration during training based on iteration length defined in State. Iteration length is a private variable in State and should have no effect by default.

commit-id:bdbe33f2
j316chuck pushed a commit that referenced this pull request Mar 29, 2024
Adds ITERATION_START, ITERATION_END, and ITERATION_CHECKPOINT to Event, Engine, and Callback. Increments iteration during training based on iteration length defined in State. Iteration length is a private variable in State and should have no effect by default.

commit-id:bdbe33f2
j316chuck pushed a commit that referenced this pull request May 16, 2024
Adds ITERATION_START, ITERATION_END, and ITERATION_CHECKPOINT to Event, Engine, and Callback. Increments iteration during training based on iteration length defined in State. Iteration length is a private variable in State and should have no effect by default.

commit-id:bdbe33f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants