Include ICD11 mappings #486
Conversation
| @@ -16,5 +16,5 @@ WHERE { | |||
| oboInOwl:hasDbXref ?xref ; | |||
| ?p1 ?o2 . | |||
| } | |||
| FILTER( STRSTARTS(str(?xref), "UMLS_ICD9CM_2005_AUI:") || STRSTARTS(str(?xref), "ICD11:") || STRSTARTS(str(?xref), "SNOMEDCT_US_") || STRSTARTS(str(?xref), "IMDRF:") || STRSTARTS(str(?xref), "url:") ) | |||
There was a problem hiding this comment.
Just commenting on my understanding.
I see what's going on here to address #140. So this deletion query gets run on the DOID and NCIT components, removing these xrefs. You're removing ICD11 from this query, so thus we're adding the mappings back from these files, as they won't be removed any longer.
I thought that #140 had something to do with my new ICD11Foundation work but it does not.
| @@ -16,5 +16,5 @@ WHERE { | |||
| oboInOwl:hasDbXref ?xref ; | |||
| ?p1 ?o2 . | |||
| } | |||
| FILTER( STRSTARTS(str(?xref), "UMLS_ICD9CM_2005_AUI:") || STRSTARTS(str(?xref), "ICD11:") || STRSTARTS(str(?xref), "SNOMEDCT_US_") || STRSTARTS(str(?xref), "IMDRF:") || STRSTARTS(str(?xref), "url:") ) | |||
| FILTER( STRSTARTS(str(?xref), "UMLS_ICD9CM_2005_AUI:") || STRSTARTS(str(?xref), "SNOMEDCT_US_") || STRSTARTS(str(?xref), "IMDRF:") || STRSTARTS(str(?xref), "url:") ) | |||
There was a problem hiding this comment.
Merging into develop or main
@hrshdhgd I see that this is merging into main, but basically from now on, per #405 (which isn't completed yet) we're going to follow the normal git flow of main <-- develop <-- feature branches.
We could change the base on this PR but IDK how much it matters. I update develop from master regularly as needed anyway.
There was a problem hiding this comment.
@hrshdhgd I approve as well as Nico. Prolly good to merge. I can update develop later.
Resolves #140 and Addresses #16 (bullet 3)
Overview
This PR:
New Packages
Were any new Python packages added?
Were any other non-Python packages added?
PR Review and Conversations Resolved
Has the PR been sufficiently reviewed by at least 1 team member of the Mondo Technical team and all threads resolved?