Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ICD11 mappings back #140

Closed
hrshdhgd opened this issue Jan 23, 2023 · 5 comments · Fixed by #486
Closed

Add ICD11 mappings back #140

hrshdhgd opened this issue Jan 23, 2023 · 5 comments · Fixed by #486
Assignees
Labels

Comments

@hrshdhgd
Copy link
Member

Follow-up to : #135.

As per this PR we are DELETEing the prefix ICD11: as a dbxref. We need to add it back when needed.

@hrshdhgd hrshdhgd self-assigned this Jan 23, 2023
@joeflack4
Copy link
Contributor

Hey @hrshdhgd , do you think there is still some work needed? This isn't related to #16 is it? Is this just about adding an ICD11 dbxref to a SPARQL query?

@matentzn
Copy link
Member

This is related to

https://github.com/monarch-initiative/mondo-ingest/blob/main/src/sparql/rm_xref_by_prefix.ru#L19

where we exclude ICD11 mappings from DOID (and other sources), once we have an active alignment process with ICD11, we should add this back.

@joeflack4 joeflack4 changed the title Add ICD11 back Add ICD11 mappings back May 22, 2023
@joeflack4
Copy link
Contributor

@hrshdhgd Just FYI, #434 will be merged soon. I suppose whenever you have time, you can handle this, maybe after the merge?

New ICD11Foundation prefixes
Or maybe you can tackle it whenever, as it looks to me like all of the new ICD11Foundation prefixes are already in all of the right places in develop. icd11.foundation has been added, along with 2 others. icd11.foundation is the one you need to be primarily concerned with, as it is on all the classes. There's also icd11.z, but IIRC this is just for retired classes, and there aren't many. The 3rd one is icd11.schema.

Old ICD11 prefix
I don't know if we plan on removing ICD11, but in my opinion @hrshdhgd @twhetzel @hrshdhgd, we may want to rename it. For example, all of the instances of ICD-11 in Orphanet are references to ICD11MMS (Morbidity and Mortality Statistics), so I suggest we rename ICD11 to ICD11MMS if Orphanet comprises 100% of such references, or if the other references also refer to ICD11MMS.

@joeflack4 joeflack4 added the icd11 label Apr 3, 2024
@hrshdhgd hrshdhgd mentioned this issue Apr 4, 2024
5 tasks
@hrshdhgd
Copy link
Member Author

hrshdhgd commented Apr 4, 2024

#486 takes care of this @joeflack4 . I'm not aware of any prefix changes and I'll be out after April 15th for a while. If there is any concensus on this please feel free to edit the PR and merge is as you see fir @joeflack4 .

@joeflack4
Copy link
Contributor

@hrshdhgd Thanks ill take a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants