style(vector): update aerialhybrid style BM-1085 #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vector Style UpdateVector Style updated for st_aerialhybrid |
tawera-manaena
changed the title
tawera-manaena
changed the title
tawera-manaena
changed the title
dwsilk
approved these changes
Oct 7, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 7, 2024
### Motivation As a Basemaps user, I want place names to be visually distinct based on their type. I want to be able to easily identify different geographic features based on their labels. ### Modifications 1. Deleted the following layers from the `labels.json` stylesheet: | Layers | | - | | `Place-Names` | | `Place-Names-3-12` | 2. Copied the following layers from the `aerialhybrid.json` stylesheet into the `labels.json` stylesheet: | Layers | | - | | `Place-Names-13-Water` | | `Place-Names-13-Natural` | | `Place-Names-13-Place` | | `Place-Names-3-12-Water` | | `Place-Names-3-12-Natural` | | `Place-Names-3-12-Place` | > These layers from the `aerialhybrid.json` stylesheet were styled in #987 ### Verification 1. Stylesheet comparison between the `Topographic` and `Aerial` layers where all three class types are visible: | Topographic | | - | | ![][topographic] | | Aerial (Before) - Labels: On | | - | | ![][aerial_before] | | Aerial (After) - Labels: On | | - | | ![][aerial_after] | [topographic]: https://github.com/user-attachments/assets/e6af4291-3ad9-4a97-95b3-4cebe800ec29 [aerial_before]: https://github.com/user-attachments/assets/86618577-ef5d-4166-a651-67b110c8c8df [aerial_after]: https://github.com/user-attachments/assets/1b6923c5-378c-4de1-89e9-d2d36bf1f225
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As a Basemaps user, I want place names to be visually distinct based on their type. I want to be able to easily identify different geographic features based on their labels.
Modifications
Deleted the following layers from the
aerialhybrid.jsonstylesheet:Place-NamesPlace-Names-3-12Copied the following layers from the
topographic.jsonstylesheet into theaerialhybrid.jsonstylesheet:Place-Names-13-WaterPlace-Names-13-NaturalPlace-Names-13-PlacePlace-Names-3-12-WaterPlace-Names-3-12-NaturalPlace-Names-3-12-PlaceAdjusted the styling of the new layers in the
aerialhybrid.jsonstylesheet:🔵 Water
text-fonttext-colortext-halo-colorPlace-Names-13-WaterOpen Sans Italicrgba(229, 248, 255, 1)rgba(16, 51, 64, 1)Place-Names-3-12-WaterOpen Sans Italicrgba(229, 248, 255, 1)rgba(16, 51, 64, 1)🟢 Natural
text-fonttext-colortext-halo-colorPlace-Names-13-NaturalOpen Sans Italicrgba(238, 255, 229, 1)rgba(32, 64, 16, 1)Place-Names-3-12-NaturalOpen Sans Italicrgba(238, 255, 229, 1)rgba(32, 64, 16, 1)⚫ Place
text-fonttext-colortext-halo-colorPlace-Names-13-PlaceRoboto Regularrgba(255, 252, 252, 1)rgba(32, 32, 32, 1)Place-Names-3-12-PlaceRoboto Regularrgba(255, 252, 252, 1)rgba(32, 32, 32, 1)Verification
Stylesheet comparison between
topographic.jsonandaerialhybrid.jsonwhere all three class types are visible:Zoom level comparison of updated
aerialhybrid.jsonstylesheet where backdrop imagery changes:🔵 Water
1112🟢 Natural
1112