Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(vector): update labels style BM-1086 #990

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

tawera-manaena
Copy link
Contributor

@tawera-manaena tawera-manaena commented Oct 7, 2024

Motivation

As a Basemaps user, I want place names to be visually distinct based on their type. I want to be able to easily identify different geographic features based on their labels.

Modifications

  1. Deleted the following layers from the labels.json stylesheet:

    Layers
    Place-Names
    Place-Names-3-12
  2. Copied the following layers from the aerialhybrid.json stylesheet into the labels.json stylesheet:

    Layers
    Place-Names-13-Water
    Place-Names-13-Natural
    Place-Names-13-Place
    Place-Names-3-12-Water
    Place-Names-3-12-Natural
    Place-Names-3-12-Place

    These layers from the aerialhybrid.json stylesheet were styled in style(vector): update aerialhybrid style BM-1085 #987

Verification

  1. Stylesheet comparison between the Topographic and Aerial layers where all three class types are visible:

    Topographic
    Aerial (Before) - Labels: On
    Aerial (After) - Labels: On

Copy link
Contributor

github-actions bot commented Oct 7, 2024

Vector Style Update

Vector Style updated for st_labels

@tawera-manaena tawera-manaena added this pull request to the merge queue Oct 7, 2024
Merged via the queue into master with commit f8fd0c2 Oct 7, 2024
7 checks passed
@tawera-manaena tawera-manaena deleted the feat/update-labels-style branch October 7, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants