Skip to content

Commit

Permalink
style(vector): update labels style BM-1086 (#990)
Browse files Browse the repository at this point in the history
### Motivation

As a Basemaps user, I want place names to be visually distinct based on
their type. I want to be able to easily identify different geographic
features based on their labels.

### Modifications

1. Deleted the following layers from the `labels.json` stylesheet:

   | Layers |
   | - |
   | `Place-Names` |
   | `Place-Names-3-12` |

2. Copied the following layers from the `aerialhybrid.json` stylesheet
into the `labels.json` stylesheet:

   | Layers |
   | - |
   | `Place-Names-13-Water` |
   | `Place-Names-13-Natural` |
   | `Place-Names-13-Place` |
   | `Place-Names-3-12-Water` |
   | `Place-Names-3-12-Natural` |
   | `Place-Names-3-12-Place` |

> These layers from the `aerialhybrid.json` stylesheet were styled in
#987

### Verification

1. Stylesheet comparison between the `Topographic` and `Aerial` layers
where all three class types are visible:

   | Topographic |
   | - |
   | ![][topographic] |

   | Aerial (Before) - Labels: On |
   | - |
   | ![][aerial_before] |

   | Aerial (After) - Labels: On |
   | - |
   | ![][aerial_after] |

[topographic]:
https://github.com/user-attachments/assets/e6af4291-3ad9-4a97-95b3-4cebe800ec29
[aerial_before]:
https://github.com/user-attachments/assets/86618577-ef5d-4166-a651-67b110c8c8df
[aerial_after]:
https://github.com/user-attachments/assets/1b6923c5-378c-4de1-89e9-d2d36bf1f225
  • Loading branch information
tawera-manaena authored Oct 7, 2024
1 parent 6f49106 commit f8fd0c2
Showing 1 changed file with 370 additions and 37 deletions.
Loading

0 comments on commit f8fd0c2

Please sign in to comment.