feat: return proper transaction receipt

[troggy]

Resolves #256

Requires:

• feat: add to/from/value getters to Transaction class leap-core#127
• tests: fix for newer leap-core with to/from/value in toJSON() #299
• feat: allow to sendTransaction and get TransactionReceipt leap-provider#1

Attempt to properly implement getTransactionReceipt RPC.

As a result, no hacks should be needed anymore for sending transactions.

Web3:

// create some LeapTransaction
const tx = Tx.transfer(
  ...
);

// tx should be signed
tx.signAll(wallet.privateKey);

const plasmaWeb3 = helpers.extendWeb3(new Web3('https://testnet-node.leapdao.org'));

// send with regular `sendSignedTransaction`
const receipt = await plasmaWeb3.eth.sendSignedTransaction(tx.hex());
// tx is included at this point\

Ethers requires a special provider due to strict checks:

const LeapProvider = require('leap-provider');
const provider = new LeapProvider('https://testnet-node.leapdao.org');

// create some LeapTransaction
const tx = Tx.transfer(
  ...
);

// tx should be signed
tx.signAll(wallet.privateKey);

// send via provider
const resp = await wallet.provider.sendTransaction(tx);

// wait for inclusion, you will get a proper TransactionReceipt once tx is included in a block
const receipt = await resp.wait();
console.log(receipt);
// tx is included at this point\

[codecov]

Codecov Report

Merging #293 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #293      +/-   ##
==========================================
+ Coverage    94.2%   94.22%   +0.01%     
==========================================
  Files          63       65       +2     
  Lines         932      935       +3     
  Branches      175      174       -1     
==========================================
+ Hits          878      881       +3     
  Misses         49       49              
  Partials        5        5

Impacted Files	Coverage Δ
src/api/methods/txResponse.js	100% <100%> (ø)	⬆️
src/api/methods/getBlockByHash.js	100% <100%> (ø)	⬆️
src/api/methods/utils/getPrevTx.js	100% <100%> (ø)
src/api/methods/getTransactionReceipt.js	100% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a99a059...03a779c. Read the comment docs.

[sunify]

One tiny change required. 🌮

[sunify]

Should be a hex string (according web3 docs and geth code)

[sunify]

👍