Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON RPC: tx response should return zero address for the from address if it is missing #290

Closed
troggy opened this issue Jul 10, 2019 · 1 comment
Closed

JSON RPC: tx response should return zero address for the from address if it is missing #290

troggy opened this issue Jul 10, 2019 · 1 comment

Comments

@troggy
Copy link
Member

troggy commented Jul 10, 2019

There is no from address for many Leap transactions (e.g. Deposit), however it is required per spec (?). Ethers.js checks rpc responses for validity and fails if they not.

Let's return zero address (0x000...0) here as a fallback.
@troggy troggy mentioned this issue Jul 10, 2019
Merged
@troggy
Copy link
Member Author

troggy commented Aug 28, 2019

closed via #293

@troggy troggy closed this as completed Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@troggy