-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow to sendTransaction and get TransactionReceipt #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
index.js
Outdated
let params = { signedTransaction: signedTransaction.hex() }; | ||
return this.perform('sendTransaction', params).then((hash) => { | ||
return this._wrapTransaction({ hash: signedTransaction.hash() }, hash); | ||
}, function (error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use arrow function here as well?
package.json
Outdated
"author": "Kosta Korenkov <[email protected]>", | ||
"license": "MIT", | ||
"dependencies": { | ||
"ethers": "^4.0.33" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move ethers
to peer deps may be a good idea to avoid double bundling for browser code
https://nodejs.org/es/blog/npm/peer-dependencies/#the-problem-plugins
For the provider to work, leap-node requires to run this change: leapdao/leap-node#293
Then it should be possible to send transactions normally without hacks:
Relates leapdao/leap-node#256