feat: rewrite update-style-exceptions.sh as a Lean executable
#13245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grunweg
added
awaiting-review
CI
This was referenced May 26, 2024
leanprover-community-mathlib4-bot
added
the
blocked-by-other-PR
grunweg
force-pushed
the
MR-rewrite-update-style-exceptions
branch
from
9316267
to
93a117c
Compare
… scripts/ It is needed in other scripts: the easiest way to depend on this is to move this to mathlib. Better places are welcome!
I'm passing all files as command line arguments: this is not how you're supposed to do it, but as a stop-gap measure, this is fine.
grunweg
force-pushed
the
MR-rewrite-update-style-exceptions
branch
from
93a117c
to
00109e5
Compare
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 1, 2024
… `scripts` (#13339) With #13245, two scripts in `scripts` would like to use very similar information: move it to a central place instead (a file in `Mathlib/Util`). Suggestions for better locations are welcome! Also, split the `getAll` function in two pieces, getting the file names and transforming this into module names. While #11853 only requires the latter, #13245 needs the former (which is computed anyway). Only accessible the converted module names and converting them back to files would be absurd. - [x] depends on: #11853 which adds these utility functions
leanprover-community-mathlib4-bot
added
merge-conflict
|
This PR/issue depends on: |
grunweg
removed
the
merge-conflict
grunweg
commented
Jun 1, 2024
| println! "error {out.exitCode} on updating style exceptions : {out.stderr}" | ||
| return out.exitCode | ||
| let lines := out.stdout.splitOn "\n" | ||
| let final := "\n".intercalate (lines.toArray.qsort (· < ·)).toList |
There was a problem hiding this comment.
I'm not too happy about the list->array->list conversion: this is because
splitOnreturns aList Stringqsortrequires anArrayto sortintercalaterequires aList Stringagain
Suggestions for avoiding this as welcome. It seems this difference isn't important for speed; this is purely an aesthetic thing.
callesonne
pushed a commit
that referenced
this pull request
Jun 4, 2024
… `scripts` (#13339) With #13245, two scripts in `scripts` would like to use very similar information: move it to a central place instead (a file in `Mathlib/Util`). Suggestions for better locations are welcome! Also, split the `getAll` function in two pieces, getting the file names and transforming this into module names. While #11853 only requires the latter, #13245 needs the former (which is computed anyway). Only accessible the converted module names and converting them back to files would be absurd. - [x] depends on: #11853 which adds these utility functions
grunweg
added a commit
that referenced
this pull request
Jun 7, 2024
… `scripts` (#13339) With #13245, two scripts in `scripts` would like to use very similar information: move it to a central place instead (a file in `Mathlib/Util`). Suggestions for better locations are welcome! Also, split the `getAll` function in two pieces, getting the file names and transforming this into module names. While #11853 only requires the latter, #13245 needs the former (which is computed anyway). Only accessible the converted module names and converting them back to files would be absurd. - [x] depends on: #11853 which adds these utility functions
|
Just as an update: I have an even better than rewriting just this file in Lean. Instead, I propose merging |
AntoineChambert-Loir
pushed a commit
that referenced
this pull request
Jun 20, 2024
… `scripts` (#13339) With #13245, two scripts in `scripts` would like to use very similar information: move it to a central place instead (a file in `Mathlib/Util`). Suggestions for better locations are welcome! Also, split the `getAll` function in two pieces, getting the file names and transforming this into module names. While #11853 only requires the latter, #13245 needs the former (which is computed anyway). Only accessible the converted module names and converting them back to files would be absurd. - [x] depends on: #11853 which adds these utility functions
leanprover-community-mathlib4-bot
added
the
merge-conflict
|
Let me close this in favour of #14273. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows running both the Python and Lean style linters.
As a user, replace
./scripts/update-style-exceptions.shbylake exe update_style_exceptions.The Lean version is slightly slower (1s vs 0.5), presumably due to some overhead of spawning processes/using
xargsthe way I do. I'm not inclined to worry.scripts#13339 to remove the copy-pasted code frommk_all.lean