-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore: don't import Lake
under Mathlib
#13779
Conversation
!bench |
Here are the benchmark results for commit 51d110d. Benchmark Metric Change
=================================
+ lint instructions -12.5%
+ lint wall-clock -14.7% |
!bench |
Here are the benchmark results for commit 9d4d9e4. Benchmark Metric Change
=================================
- build linting 5.2%
+ lint instructions -12.5%
+ lint wall-clock -14.6% |
!bench |
Thanks a lot for investigating this - I would have been (and still am) completely stumped by them! |
Here are the benchmark results for commit 87579f6. Benchmark Metric Change
=================================
- build linting 7.2%
+ lint instructions -12.5%
+ lint wall-clock -13.8% |
Adding the file to |
Oh wait. I'm reading this wrong. The file itself is fine. |
This reverts commit 87579f6.
!bench |
Here are the benchmark results for commit d2f495e. |
Until it is added to |
!bench |
Here are the benchmark results for commit 18cb303. Benchmark Metric Change
============================
- build linting 6.9% |
!bench |
Here are the benchmark results for commit 9ab3ce4. Benchmark Metric Change
=================================
+ lint instructions -12.5%
+ lint wall-clock -14.7% |
!bench |
PR summary 3d9182a4a1Import changesDependency changes
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
scripts
(#13339)"Lake
under Mathlib
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, thanks a lot for finding this! As a next step, I'll augment the Python lint to complain about any lake imports in Mathlib, referring to this issue :-)
This PR is just code motion, so looks fine to me. My original use-case #13245 doesn't need getLeanLibs
anyway (and its proposed replacement won't either), so moving this function back looks good to me.
Actually, since you marked this as awaiting-review and CI on this was successful previously, let me go straight to |
🚀 Pull request has been placed on the maintainer queue by grunweg. |
Here are the benchmark results for commit 16c93ae. Benchmark Metric Change
=================================
+ lint instructions -12.5%
+ lint wall-clock -14.7% |
bors merge |
The `Lake.CLI.Main` import was slowing down linting by ~90s/~15% on its own. We move the function `getLeanLibs` back to `scripts/mk_all.lean` to avoid the import. Co-authored-by: Matthew Robert Ballard <[email protected]>
Build failed (retrying...): |
The `Lake.CLI.Main` import was slowing down linting by ~90s/~15% on its own. We move the function `getLeanLibs` back to `scripts/mk_all.lean` to avoid the import. Co-authored-by: Matthew Robert Ballard <[email protected]>
Pull request successfully merged into master. Build succeeded: |
Lake
under Mathlib
Lake
under Mathlib
Co-authored-by: Matthew Ballard <[email protected]>
The `Lake.CLI.Main` import was slowing down linting by ~90s/~15% on its own. We move the function `getLeanLibs` back to `scripts/mk_all.lean` to avoid the import. Co-authored-by: Matthew Robert Ballard <[email protected]>
Co-authored-by: Matthew Ballard <[email protected]>
The
Lake.CLI.Main
import was slowing down linting by ~90s/~15% on its own. We move the functiongetLeanLibs
back toscripts/mk_all.lean
to avoid the import.