[Merged by Bors] - refactor: tweak and move functionality for getting all modules out of scripts
#13339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grunweg
added
awaiting-review
CI
leanprover-community-mathlib4-bot
added
the
blocked-by-other-PR
1 task
leanprover-community-mathlib4-bot
removed
the
blocked-by-other-PR
|
This PR/issue depends on:
|
leanprover-community-mathlib4-bot
added
the
merge-conflict
grunweg
removed
merge-conflict
grunweg
force-pushed
the
MR-extract-module-utils
branch
from
7b84fa1
to
09c2feb
Compare
… scripts/ It is needed in other scripts: the easiest way to depend on this is to move this to mathlib. Better places are welcome!
grunweg
force-pushed
the
MR-extract-module-utils
branch
from
09c2feb
to
629199e
Compare
adomani
approved these changes
Jun 1, 2024
|
This looks good to me! The rename of the variable should have really happened when I refactored the code, but I only noticed it now. Thanks! (I won't be at a computer until Monday, so I can't really test this code right now.) |
|
For the future, |
kim-em
reviewed
Jun 1, 2024
|
bors d+ |
|
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
|
Thanks for the quick review |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 1, 2024
… `scripts` (#13339) With #13245, two scripts in `scripts` would like to use very similar information: move it to a central place instead (a file in `Mathlib/Util`). Suggestions for better locations are welcome! Also, split the `getAll` function in two pieces, getting the file names and transforming this into module names. While #11853 only requires the latter, #13245 needs the former (which is computed anyway). Only accessible the converted module names and converting them back to files would be absurd. - [x] depends on: #11853 which adds these utility functions
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
scriptsscripts
callesonne
pushed a commit
that referenced
this pull request
Jun 4, 2024
… `scripts` (#13339) With #13245, two scripts in `scripts` would like to use very similar information: move it to a central place instead (a file in `Mathlib/Util`). Suggestions for better locations are welcome! Also, split the `getAll` function in two pieces, getting the file names and transforming this into module names. While #11853 only requires the latter, #13245 needs the former (which is computed anyway). Only accessible the converted module names and converting them back to files would be absurd. - [x] depends on: #11853 which adds these utility functions
grunweg
added a commit
that referenced
this pull request
Jun 7, 2024
… `scripts` (#13339) With #13245, two scripts in `scripts` would like to use very similar information: move it to a central place instead (a file in `Mathlib/Util`). Suggestions for better locations are welcome! Also, split the `getAll` function in two pieces, getting the file names and transforming this into module names. While #11853 only requires the latter, #13245 needs the former (which is computed anyway). Only accessible the converted module names and converting them back to files would be absurd. - [x] depends on: #11853 which adds these utility functions
AntoineChambert-Loir
pushed a commit
that referenced
this pull request
Jun 20, 2024
… `scripts` (#13339) With #13245, two scripts in `scripts` would like to use very similar information: move it to a central place instead (a file in `Mathlib/Util`). Suggestions for better locations are welcome! Also, split the `getAll` function in two pieces, getting the file names and transforming this into module names. While #11853 only requires the latter, #13245 needs the former (which is computed anyway). Only accessible the converted module names and converting them back to files would be absurd. - [x] depends on: #11853 which adds these utility functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #13245, two scripts in
scriptswould like to use very similar information:move it to a central place instead (a file in
Mathlib/Util). Suggestions for better locations are welcome!Also, split the
getAllfunction in two pieces, getting the file names and transforming this into module names.While #11853 only requires the latter, #13245 needs the former (which is computed anyway).
Only accessible the converted module names and converting them back to files would be absurd.
lake exe mk_allas a Lean executable #11853 which adds these utility functions