-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pt-PT] Replaced rule ID:ENSINO_SUPERIOR with ID:ENSINO_SUPERIOR_V2 and moved to academic #10931
Conversation
…nd moved to academic
WalkthroughThe pull request introduces significant modifications to the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (3)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml (3)
3402-3447
: Well-structured new rule group for "Ensino Superior".The new rule group 'ENSINO_SUPERIOR_V2' is a good addition to improve consistency in academic language. It correctly handles different prepositions and uses case-insensitive matching.
Consider the following suggestions:
- Add a comment explaining why this rule is set to "temp_off" by default.
- Include examples in the rule descriptions to aid in testing and documentation.
- Consider adding a
<url>
tag with a reference to support this language preference.Would you like me to draft these additions for you?
Line range hint
3463-3478
: Expanded coverage and refined exceptions in 'CIENTÍFICO_MAIS_IMPORTANTE_CHAVE_V3' rule.The modifications to this rule significantly improve its scope and accuracy. The expanded list of nouns in the pattern increases the rule's applicability, while the extended exceptions list helps prevent false positives.
To ensure the continued effectiveness of this rule:
- Consider implementing a system for regularly reviewing and updating the exceptions list based on user feedback or corpus analysis.
- Document the criteria for adding words to the exceptions list to maintain consistency in future updates.
Would you like me to draft a plan for maintaining and updating this rule?
Line range hint
3480-3524
: Well-designed new rule 'VERBO_PRONOMINAL_DE_V3' for formal style simplification.This new rule effectively addresses the simplification of pronominal verbs in formal Portuguese by suggesting the removal of the preposition 'de'. The comprehensive list of exceptions helps to prevent false positives and maintain accuracy.
To further improve this rule:
- Add comments explaining the rationale behind this simplification for future maintainers.
- Include a few example sentences in the rule description to illustrate correct and incorrect usage.
- Consider adding a
<url>
tag with a reference to a style guide or linguistic resource that supports this simplification.- Implement a testing strategy to ensure the rule works correctly with various verb forms and contexts.
Would you like me to draft these additions or create a testing plan for this rule?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml (1 hunks)
🧰 Additional context used
🔇 Additional comments (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml (1)
Line range hint
3449-3461
: Improved context and suggestion in 'CIENTÍFICO_DETERMINADAS_ESPECÍFICAS' rule.The modifications to this rule enhance its accuracy and usefulness. The extended context consideration (up to 4 tokens) allows for better pattern matching, and the updated suggestion preserves the original adjective while replacing only the target word.
Just replaced the old rule with a more accurate one.
Summary by CodeRabbit
New Features
General Improvements