Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt-PT] Replaced rule ID:ENSINO_SUPERIOR with ID:ENSINO_SUPERIOR_V2 and moved to academic #10931

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

marcoagpinto
Copy link
Member

@marcoagpinto marcoagpinto commented Oct 13, 2024

Just replaced the old rule with a more accurate one.

Summary by CodeRabbit

  • New Features

    • Introduced a new rule group for Higher Education terminology, replacing "Educação Superior" with "Ensino Superior."
    • Added new rules for clarity, simplification, and formal language adjustments in Portuguese.
    • Enhanced existing rules to improve accuracy and address redundancies and pleonasms.
  • General Improvements

    • Refined overall structure of language rules for better organization and clarity.

Copy link
Contributor

coderabbitai bot commented Oct 13, 2024

Walkthrough

The pull request introduces significant modifications to the style.xml file for Portuguese language rules in LanguageTool. Key changes include the addition of a new rule group for higher education terminology, enhancements to existing rules for clarity, and the introduction of simplification and redundancy rules. Additionally, adjustments have been made to ensure appropriate language use in formal contexts, alongside an overall refinement of the rules' structure for improved organization and clarity.

Changes

File Path Change Summary
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml - Added new rule group ENSINO_SUPERIOR_V2.
- Introduced rules for replacing "Educação Superior" with "Ensino Superior".
- Added rule DIFICULDADES_PROVAÇÕES.
- Added rule AVOID_GERUND_ALL.
- Added rule FORMAL_DEPRECIATIVO.
- Added rule SIMPLIFICAR_À_VERBO_DE.

Possibly related PRs

Suggested reviewers

  • p-goulart
  • susanaboatto

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (3)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml (3)

3402-3447: Well-structured new rule group for "Ensino Superior".

The new rule group 'ENSINO_SUPERIOR_V2' is a good addition to improve consistency in academic language. It correctly handles different prepositions and uses case-insensitive matching.

Consider the following suggestions:

  1. Add a comment explaining why this rule is set to "temp_off" by default.
  2. Include examples in the rule descriptions to aid in testing and documentation.
  3. Consider adding a <url> tag with a reference to support this language preference.

Would you like me to draft these additions for you?


Line range hint 3463-3478: Expanded coverage and refined exceptions in 'CIENTÍFICO_MAIS_IMPORTANTE_CHAVE_V3' rule.

The modifications to this rule significantly improve its scope and accuracy. The expanded list of nouns in the pattern increases the rule's applicability, while the extended exceptions list helps prevent false positives.

To ensure the continued effectiveness of this rule:

  1. Consider implementing a system for regularly reviewing and updating the exceptions list based on user feedback or corpus analysis.
  2. Document the criteria for adding words to the exceptions list to maintain consistency in future updates.

Would you like me to draft a plan for maintaining and updating this rule?


Line range hint 3480-3524: Well-designed new rule 'VERBO_PRONOMINAL_DE_V3' for formal style simplification.

This new rule effectively addresses the simplification of pronominal verbs in formal Portuguese by suggesting the removal of the preposition 'de'. The comprehensive list of exceptions helps to prevent false positives and maintain accuracy.

To further improve this rule:

  1. Add comments explaining the rationale behind this simplification for future maintainers.
  2. Include a few example sentences in the rule description to illustrate correct and incorrect usage.
  3. Consider adding a <url> tag with a reference to a style guide or linguistic resource that supports this simplification.
  4. Implement a testing strategy to ensure the rule works correctly with various verb forms and contexts.

Would you like me to draft these additions or create a testing plan for this rule?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 3c9e306 and 176e560.

📒 Files selected for processing (1)
  • languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml (1 hunks)
🧰 Additional context used
🔇 Additional comments (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml (1)

Line range hint 3449-3461: Improved context and suggestion in 'CIENTÍFICO_DETERMINADAS_ESPECÍFICAS' rule.

The modifications to this rule enhance its accuracy and usefulness. The extended context consideration (up to 4 tokens) allows for better pattern matching, and the updated suggestion preserves the original adjective while replacing only the target word.

@marcoagpinto marcoagpinto merged commit 20d222e into master Oct 13, 2024
5 checks passed
@marcoagpinto marcoagpinto deleted the lt_marcoagpinto_20241013_2137 branch October 13, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant