[pt-PT] Improved rule ID:CONFUSÃO_CAIXA_EMBALAGEM and cleaned other rule #10932
Conversation
WalkthroughThe pull request introduces comprehensive modifications to the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (3)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml (3)
Line range hint
89-102: Improved rule coverage and efficiency.The changes to the CONFUSÃO_CAIXA_EMBALAGEM rule are well-implemented. The expanded verb list using a regular expression improves the rule's coverage and maintainability. Setting the rule to "temp_off" is a good precaution while testing these changes.
Consider adding a comment explaining why the rule is temporarily disabled and when it should be re-enabled.
Line range hint
123-133: Well-implemented new rule for common language misconception.The addition of the CICLO_VICIOSO rule is a valuable improvement. It addresses a common language error and provides a helpful suggestion. The inclusion of a reference URL is excellent for providing context.
Consider adding an example that demonstrates a correct usage of "círculo vicioso" to further clarify the rule's application.
Line range hint
136-271: Improved accuracy of gerund detection with new antipatterns.The changes to the AVOID_GERUND rule group are well-implemented. The addition of new antipatterns and refinements to existing rules should significantly reduce false positives while maintaining the rule's effectiveness in identifying unnecessary gerund usage.
Consider adding comments to explain the purpose of each antipattern, which would improve maintainability and make it easier for other contributors to understand and extend the rules in the future.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml (2 hunks)
🧰 Additional context used
🔇 Additional comments (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml (1)
Line range hint
105-120: Refined rule to prevent false positives.The addition of the exception
<exception scope='previous' postag_regexp='yes' postag='V.+'/></token>in the PRAZER_GOSTO rule is a good improvement. This change should help prevent false positives by excluding cases where the previous word is a verb.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (3)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml (3)
Line range hint
104-120: Good refinement of the 'PRAZER_GOSTO' rule.The addition of the exception
<exception scope='previous' postag_regexp='yes' postag='V.+'/></token>helps prevent false positives when "prazer" is preceded by verb forms. This should improve the rule's accuracy.To enhance clarity, consider adding a comment explaining the purpose of this exception, such as:
<!-- Exclude cases where 'prazer' is preceded by a verb, e.g., "ter prazer em" -->This will help other developers understand the reasoning behind the exception.
Line range hint
123-134: Excellent addition of the 'CICLO_VICIOSO' rule!This new rule addresses a common language misconception in Portuguese, helping users improve their writing by suggesting the correct phrase "círculo vicioso" instead of "ciclo vicioso".
To further enhance this rule, consider adding a short message explaining why "círculo vicioso" is preferred over "ciclo vicioso". This could be done by modifying the
<message>tag:<message>Substitua por <suggestion>círculo vicioso</suggestion>. "Círculo vicioso" é a expressão correta para descrever uma situação problemática que se perpetua.</message>This additional explanation will help users understand the reason for the correction, potentially improving their language skills.
Line range hint
137-255: Valuable refinements to the 'AVOID_GERUND' rule group.The addition of multiple antipatterns significantly improves the rule's accuracy by excluding valid uses of the gerund. This should reduce false positives and make the rule more reliable.
To enhance maintainability and readability, consider grouping related antipatterns and adding comments to explain the purpose of each group. For example:
<!-- Antipatterns for specific verb combinations --> <antipattern> <!-- existing antipattern --> </antipattern> <!-- Antipatterns for gerunds with pronouns --> <antipattern> <!-- existing antipattern --> </antipattern> <!-- Add more grouped antipatterns with explanatory comments -->This organization will make it easier for future contributors to understand and modify the rule as needed.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml (2 hunks)
🧰 Additional context used
🔇 Additional comments (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml (1)
Line range hint
89-101: Excellent improvements to the 'CONFUSÃO_CAIXA_EMBALAGEM' rule!The changes enhance the rule's functionality and accuracy:
- Adding
default="temp_off"allows for easier testing and gradual deployment.- Using a regular expression for verb matching increases the rule's coverage.
- The new suggestion with
postag_replaceshould provide more accurate corrections.These modifications should make the rule more effective in identifying and correcting confusion between "caixa" and "embalagem" in pharmaceutical contexts.
Improved the rule with more verbs, but it still has zero hits.
Summary by CodeRabbit
New Features
Improvements