[pt] Improved the disambiguation.xml #10868

marcoagpinto · 2024-09-08T09:42:30Z

Heya, @jaumeortola , @susanaboatto and @p-goulart ,

This enhancement fixes sentences like:

A equipe fundiu as duas como uma forma de meio-termo.
A equipe fundiu as suas duas como uma forma de meio-termo.
A equipe fundiu umas duas como uma forma de meio-termo.

“como” no longer appears as a noun nor as a verb.

It should be a low-impact change since it is a strict rule, but one must look at the nightly diffs.

😛 😛 😛 😛 😛 😛 😛 😛

Summary by CodeRabbit

New Features
- Introduced a new disambiguation rule for the Portuguese language module to enhance grammatical accuracy by refining the handling of specific verb forms in context.

coderabbitai · 2024-09-08T09:42:38Z

Walkthrough

The pull request introduces a new disambiguation rule in the Portuguese language module of LanguageTool. This rule specifies a pattern that matches a sequence of tokens based on their part-of-speech (POS) tags, including verbs, determiners, and specific tokens. The rule includes a marker for first-person singular verbs and defines an action to remove certain matching tokens. This change enhances the tool's ability to process verb forms in grammatical checks.

Changes

Files	Change Summary
`languagetool-language-modules/pt/src/main/resources/.../disambiguation.xml`	Added a new `<rule>` with a specific POS pattern for disambiguation.

Possibly related PRs

[pt-PT] Added APs to rule ID:VERBO_HIFENIZADOR_VERBOS_2 #10867: Involves adding new antipatterns related to Portuguese grammar rules, relevant to enhancing the Portuguese language module.

Suggested labels

Portuguese

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 826be45 and b9e57d5.

Files selected for processing (1)

languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml (1 hunks)

Additional comments not posted (1)

languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml (1)

240-250: Review of the new disambiguation rule for handling "como"

The new rule added from lines 240 to 250 aims to address the misclassification of "como" in specific contexts by removing certain POS tags when the pattern matches. The rule is well-formed and targets the correct sequence of tokens with the specified POS tags. This should effectively improve the handling of "como" in the mentioned contexts.

However, it's crucial to ensure that this rule does not interfere with other valid usages of "como" in different contexts. It would be beneficial to add more examples within the rule to demonstrate its correct application and to ensure it does not produce unintended matches.

Please consider adding more example sentences to this rule to demonstrate its effectiveness and to ensure it does not affect other usages of "como". Would you like me to suggest some example sentences based on typical usages in Portuguese?

jaumeortola · 2024-09-08T09:55:27Z

...etool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml

+        <token min='1' max='2' postag="[DP].+" postag_regexp="yes"/>
+        <token postag="Z0[FM]P0" postag_regexp="yes"/>
+        <marker>
+          <token postag="VMIP1S0" postag_regexp="no"/>


If this rule is intended only to disambiguate "como", you could write explicitly "como" there. It will be safer.

@jaumeortola

I am not sure if it only works with “como”.

It also works with “logo”.

I based myself on the rule I was working on.

I was expecting to look at the night diff to see the results and later fix it in case there are false positives.

Anyway, something is missing. If the word inside the <marker> is only verb (or verb and noun), all POS tags will be removed. I would add some other conditions: specific words (como, logo), or other POS tags (CS, PT, RG...)

@jaumeortola

I have done it hours ago.

Let me refresh the review.

marcoagpinto · 2024-09-08T10:37:38Z

@jaumeortola

Done!

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b9e57d5 and 6cd36fb.

Files selected for processing (1)

languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml (1 hunks)

Files skipped from review as they are similar to previous changes (1)

languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml

[pt] Improved the disambiguation.xml

b9e57d5

marcoagpinto added the Portuguese label Sep 8, 2024

marcoagpinto requested review from jaumeortola, p-goulart and susanaboatto September 8, 2024 09:42

coderabbitai bot reviewed Sep 8, 2024

View reviewed changes

jaumeortola reviewed Sep 8, 2024

View reviewed changes

[pt] Made changes suggested by Jaume

6cd36fb

coderabbitai bot reviewed Sep 8, 2024

View reviewed changes

marcoagpinto requested a review from jaumeortola September 8, 2024 16:28

jaumeortola approved these changes Sep 8, 2024

View reviewed changes

marcoagpinto merged commit 49d0dab into master Sep 8, 2024
5 checks passed

marcoagpinto deleted the lt_marcoagpinto_20240908_1038 branch September 8, 2024 19:25

coderabbitai bot mentioned this pull request Sep 12, 2024

[pt] Added/improved APs in rule ID:GENERAL_NUMBER_AGREEMENT_ERRORS #10872

Merged

coderabbitai bot mentioned this pull request Sep 28, 2024

[pt] disambiguation.xml, improved rule ID:RARE_POS #10901

Merged

coderabbitai bot mentioned this pull request Oct 13, 2024

[pt] Fixed tons of FPs "nouns -> verbs" in disambiguation.xml #10926

Merged

coderabbitai bot mentioned this pull request Oct 20, 2024

Revert "[pt] Fixed tons of FPs "nouns -> verbs" in disambiguation.xml" #10956

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pt] Improved the disambiguation.xml #10868

[pt] Improved the disambiguation.xml #10868

marcoagpinto commented Sep 8, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 8, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

jaumeortola Sep 8, 2024 •

edited

Loading

marcoagpinto Sep 8, 2024

jaumeortola Sep 8, 2024

marcoagpinto Sep 8, 2024

marcoagpinto commented Sep 8, 2024

coderabbitai bot left a comment

[pt] Improved the disambiguation.xml #10868

[pt] Improved the disambiguation.xml #10868

Conversation

marcoagpinto commented Sep 8, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Sep 8, 2024 • edited Loading

Walkthrough

Changes

Possibly related PRs

Suggested labels

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

jaumeortola Sep 8, 2024 • edited Loading

Choose a reason for hiding this comment

marcoagpinto Sep 8, 2024

Choose a reason for hiding this comment

jaumeortola Sep 8, 2024

Choose a reason for hiding this comment

marcoagpinto Sep 8, 2024

Choose a reason for hiding this comment

marcoagpinto commented Sep 8, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

marcoagpinto commented Sep 8, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 8, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

jaumeortola Sep 8, 2024 •

edited

Loading