Revert "[pt] Fixed tons of FPs "nouns -> verbs" in disambiguation.xml"

[marcoagpinto]

Reverts #10926

@jaumeortola

Here it is, I found the button.

Summary by CodeRabbit

• New Features

  • Enhanced disambiguation rules for Portuguese, improving grammatical and contextual analysis.
  • Added new examples to style rules, providing better context for language usage.

• Bug Fixes

  • Removed outdated rule from disambiguation, simplifying verb and noun phrase interpretation.
  • Uncommented examples in grammar and style rules, improving feedback on sentence structures.

[coderabbitai]

Walkthrough

The pull request introduces modifications to the Portuguese language module in LanguageTool, specifically affecting the disambiguation.xml, grammar.xml, and style.xml files. Key changes include the removal of a rule from the RARE_POS group in disambiguation.xml, adjustments to existing rules, and the addition of new examples in both grammar.xml and style.xml. These updates aim to refine the disambiguation process and enhance the accuracy of grammatical analysis for Portuguese.

Changes

File	Change Summary
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml	Removed a rule from rulegroup id="RARE_POS" and made various adjustments to existing rules and patterns.
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml	Uncommented an example sentence in the antipattern section, making it active for processing.
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/style.xml	Uncommented several example sentences, making them active within the XML structure.

Possibly related PRs

• [pt] Improved the disambiguation.xml #10868: This PR improves the disambiguation.xml file, which is directly related to the changes made in the main PR that also modifies the disambiguation.xml file, specifically focusing on disambiguation rules.
• [pt] disambiguation.xml, improved rule ID:RARE_POS #10901: This PR enhances the RARE_POS rule in disambiguation.xml, which is relevant as the main PR also involves changes to disambiguation rules, including the removal of a specific rule in the same context.
• [pt] Fixed tons of FPs "nouns -> verbs" in disambiguation.xml #10926: This PR addresses false positives in the disambiguation.xml, which aligns with the main PR's focus on refining disambiguation rules and improving accuracy in language processing.
• [pt-PT] Removed "temp_off" from rule ID:CONCLUIR_UM_CURSO #10943: This PR removes the "temp_off" designation from the CONCLUIR_UM_CURSO rule, which is relevant as it pertains to the activation of rules in the same style context as the main PR's changes to disambiguation rules.
• [pt-PT] Disambiguator changes fixed rule ID:CONCLUIR_UM_CURSO #10953: This PR fixes issues related to the CONCLUIR_UM_CURSO rule, which is relevant as it addresses disambiguation and rule accuracy, similar to the objectives of the main PR.

Suggested reviewers

• p-goulart
• susanaboatto
• jaumeortola

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 7c8ea11 and e1296d0.

📒 Files selected for processing (3)

• languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml (0 hunks)
• languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml (1 hunks)
• languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/style.xml (3 hunks)

💤 Files with no reviewable changes (1)

• languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml

✅ Files skipped from review due to trivial changes (1)

• languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml

🧰 Additional context used

🔇 Additional comments (4)

languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/style.xml (4)

8937-8937: LGTM: New example enhances the rule set

The added example "Então Jacob abandona o bando, sendo seguido por Seth e, mais tarde, por Leah." is a good addition to the existing set of examples. It provides another clear illustration of the use of "sendo" in Portuguese, which aligns well with the surrounding context and enhances the diversity of the examples.

---

13141-13141: LGTM: New example adds technical context

The added example "O Sistema de Crenças é definido como sendo o conjunto de argumentos e os respetivos pesos." is a valuable addition to the existing set of examples. It provides a clear illustration of the use of "como sendo" in Portuguese, particularly in a more technical or academic context. This enhances the diversity and applicability of the examples in the rule set.

---

19289-19289: LGTM: New example adds contextual variety

The added example "Estava muito nublado para ver o avião." is a good addition to the existing set of examples. It provides another clear illustration of the use of "ver" in Portuguese, specifically in the context of visibility conditions. This enhances the diversity of the examples and strengthens the rule set by covering more usage scenarios.

---

8937-8937: Verify alignment with PR intention

The changes in this file consistently add valuable and diverse examples to the Portuguese language rule set, which is generally a positive improvement. However, it's important to note that the PR description indicates this is a revert operation of a previous change (PR #10926).

Given this context, please confirm if these additions are intentional and align with the goal of reverting the previous changes. If these are indeed new additions rather than reversions, it might be worth updating the PR description to clarify the scope of changes.

To help verify the nature of these changes, you can run the following script:

This script will help determine if the added lines were present in the file before the PR that's being reverted, which can clarify if these are truly reversions or new additions.

Also applies to: 13141-13141, 19289-19289

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[jaumeortola]

Thanks!