[pt] disambiguation.xml, improved rule ID:RARE_POS

[marcoagpinto]

Heya, @jaumeortola , @susanaboatto and @p-goulart ,

I have enhanced the disambiguation rule, which I created weeks ago.

Back then I added two rules, right now, I am only improving one, to do it slowly.

I created a dummy rule just to check the results.

<rulegroup id='MARCOAGPINTO_DIS_DUAS_VERB' name="Disambiguator: Duas + verb">
    <rule>
      <pattern>
        <token postag="Z0.[PN].+" postag_regexp="yes"/>
        <marker>
          <and>
            <token postag="VMIP2S0|VMN02S0|VMSF2S0" postag_regexp="yes"/>
            <token postag="NC.+" postag_regexp="yes"/>
          </and>
        </marker>
      </pattern>
        <message>Regra a testar o Disambiguator.</message>
        <short>Testar o Disambiguator.</short>
        <example correction=''>duas <marker>comes</marker></example>
    </rule>
</rulegroup>

RULE BEFORE:

Portuguese (Portugal): 902 total matches
Portuguese (Portugal): 854003 total sentences considered

0.txt

RULE AFTER (NOW):

Portuguese (Portugal): 3099 total matches
Portuguese (Portugal): 854003 total sentences considered

1.txt

The hits are so many that I couldn't check one by one, so I gave a quick look in the results and they looked valid.

Thanks!

Summary by CodeRabbit

• New Features

  • Enhanced token matching for the Portuguese language module, improving accuracy in grammar and style checks.

• Bug Fixes

  • Adjusted regex pattern for better flexibility in identifying part-of-speech tags, allowing for a broader range of matches.

[coderabbitai]

Walkthrough

The pull request modifies token patterns in the disambiguation.xml file for the Portuguese language module of LanguageTool. It updates the postag attributes of two <token> elements to broader regex patterns, allowing for a wider range of part-of-speech tag matches. Additionally, it incorporates an <and> condition in the marker section that requires specific postags.

Changes

File	Change Summary
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml	Updated postag attributes to Z0.[PN].+ for broader regex matching and added an <and> condition for postags.

Possibly related PRs

• [pt] Improved the disambiguation.xml #10868: Modifies the same disambiguation.xml file and introduces a new rule for matching tokens with specific part-of-speech tags.
• [pt] Removed "temp_off" from rule ID:OS_DOIS_AS_DUAS_AMBOS_AMBAS #10887: Involves the style.xml file, which may affect the processing of tokens in conjunction with the disambiguation rules.

Suggested reviewers

• p-goulart
• susanaboatto

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 31de892 and 1ba23d8.

📒 Files selected for processing (1)

• languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[marcoagpinto]

Heya,

I have just enhanced the second rule, now producing practical results and not just two or three hits.

Dummy rule used for the checks:

<rulegroup id='MARCOAGPINTO_DIS_COMO' name="Disambiguator: Duas + verb">

    <rule>
      <pattern>
        <token postag="V.+" postag_regexp="yes"/>
        <token min='1' max='2' postag="SPS00|(SPS00:)?[DP].+|RG|CS|VMG0000|VMN0000" postag_regexp="yes"/>
        <token postag="Z0.[PN].+" postag_regexp="yes"/>
        <marker>
          <and>
            <token postag="VMIP1S0" postag_regexp="no"/>
            <token postag="RG" postag_regexp="no"/>
          </and>
        </marker>
      </pattern>
        <message>Regra a testar o Disambiguator.</message>
        <short>Testar o Disambiguator.</short>
        <example correction=''>Quero essas duas <marker>como</marker> aquela.</example>
    </rule>

</rulegroup>

Portuguese (Portugal): 79 total matches
Portuguese (Portugal): 854003 total sentences considered

_4.txt

[marcoagpinto]

Heya, @susanaboatto and @p-goulart ,

I made this pull request two weeks ago.

And I have a total of five (5) pull requests opened.

Any news regarding them?

Thanks!

❤️ ❤️ ❤️ ❤️ ❤️

[marcoagpinto]

Thank you for the approvals!!!

❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️

On the weekend, I will make a few changes in the pt-PT structure, such as moving the ID: INFORMALITIES rule into the formal category and extracting the colloquialisms from it into a separate rulegroup for extra power and easier use.

I also have written down notes on how to further improve the rare verbs.

It is all in my TO-DO list.